Newpkg: search and rescue 2 (draft before pushing to termux-packages)#2149
Open
IntinteDAO wants to merge 1 commit intotermux-user-repository:masterfrom
Open
Newpkg: search and rescue 2 (draft before pushing to termux-packages)#2149IntinteDAO wants to merge 1 commit intotermux-user-repository:masterfrom
IntinteDAO wants to merge 1 commit intotermux-user-repository:masterfrom
Conversation
| @@ -0,0 +1,6 @@ | |||
| TERMUX_SUBPKG_DESCRIPTION="Data files for search and rescue 2 (metapackage)" | |||
| TERMUX_SUBPKG_PLATFORM_INDEPENDENT=true | |||
| TERMUX_SUBPKG_DEPEND_ON_PARENT=no | |||
Member
There was a problem hiding this comment.
This line has no effect for 2 reasons:
- it would be
falseinstead ofno - There is code that automatically makes
TERMUX_SUBPKG_DEPEND_ON_PARENT=falsewhen the subpackage is inTERMUX_PKG_DEPENDSof the parent package so you don't need to specify this anyway
Member
There was a problem hiding this comment.
Also this is not technically a "metapackage" so maybe the description should be adjusted to remove that
| + '-Wl,-rpath,' + sys_prefix + '/lib', | ||
| + '-Wl,--enable-new-dtags', | ||
| + '-landroid-spawn', | ||
| + '-Wl,--no-as-needed,-lOpenSLES,--as-needed' |
Member
There was a problem hiding this comment.
Maybe it's possible to get LDFLAGS using os.environ.get() like you did for PREFIX instead of having to write -landroid-spawn, etc. twice?
Also, similar for CPPFLAGS,
Also, For PREFIX itself, I recommend writing this: @TERMUX_PREFIX@ instead of os.environ.get('PREFIX' because @TERMUX_PREFIX@ will be automatically replaced in .patch files for slightly less code required, but that's up to you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The game should work without any problems. It is possible that the “fix_sconstruct.patch” file should be split into several smaller ones.
I must admit that I have never used scons, so I don't know if it can be written more elegantly. However, it works :) I will definitely work on it, because the serf package also uses scons, but it installs everything in termux_step_make_install.