fix: Local enable_encryption_config still reads true even when toggled off #3438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because encryption_config is now strictly defined as an object, count will never be <1 even if empty.
TheFLHurricane
changed the title
TheFLHurricane
changed the title
TheFLHurricane
changed the title
bryantbiggs
reviewed
Jul 24, 2025
| role_arn = try(aws_iam_role.this[0].arn, var.iam_role_arn) | ||
|
|
||
| create_outposts_local_cluster = var.outpost_config != null | ||
| enable_encryption_config = length(var.encryption_config) > 0 && !local.create_outposts_local_cluster |
There was a problem hiding this comment.
do you have a reproduction of what you are trying to do? I'm not quite following, and this logic change looks incorrect
3 tasks
gws
reviewed
Jul 24, 2025
|
|
||
| create_outposts_local_cluster = var.outpost_config != null | ||
| enable_encryption_config = length(var.encryption_config) > 0 && !local.create_outposts_local_cluster | ||
| enable_encryption_config = var.encryption_config != {} && !local.create_outposts_local_cluster |
There was a problem hiding this comment.
Something like this works for me, there's probably a better way to do it
Suggested change
| enable_encryption_config = var.encryption_config != {} && !local.create_outposts_local_cluster | |
| enable_encryption_config = length(coalesce(var.encryption_config.resources, [])) > 0 && !local.create_outposts_local_cluster |
|
This issue has been resolved in version 21.0.4 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because encryption_config is now strictly defined as an object, count will never be <1 even if empty.
Description
Addendum to previous PR... Changes enable_encryption_config to react to actual value of encryption_config rather than count since strict type object will always be >0.
Motivation and Context
This allows enable_encryption_config to become false when encryption_config is {} as in previous versions.
Breaking Changes
No, restores backwards compatibility.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request