Skip to content

fix: Local enable_encryption_config still reads true even when toggled off #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Local enable_encryption_config still reads true even when toggled off #3438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ locals {
role_arn = try(aws_iam_role.this[0].arn, var.iam_role_arn)

create_outposts_local_cluster = var.outpost_config != null
enable_encryption_config = length(var.encryption_config) > 0 && !local.create_outposts_local_cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have a reproduction of what you are trying to do? I'm not quite following, and this logic change looks incorrect

enable_encryption_config = var.encryption_config != {} && !local.create_outposts_local_cluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this works for me, there's probably a better way to do it

Suggested change
enable_encryption_config = var.encryption_config != {} && !local.create_outposts_local_cluster
enable_encryption_config = length(coalesce(var.encryption_config.resources, [])) > 0 && !local.create_outposts_local_cluster


auto_mode_enabled = try(var.compute_config.enabled, false)
}
Expand Down
Loading