fix: Don't retrieve ssm param if custom ami used#3660
Open
samuelallan72 wants to merge 1 commit intoterraform-aws-modules:masterfrom
Open
fix: Don't retrieve ssm param if custom ami used#3660samuelallan72 wants to merge 1 commit intoterraform-aws-modules:masterfrom
samuelallan72 wants to merge 1 commit intoterraform-aws-modules:masterfrom
Conversation
The ssm param for the recommended ami is not used if a custom ami is used.
Also, if one wishes to use a custom ami with the older AL2 ami_type (uses bootstrap.sh for user_data in launch templates),
retrieving the ssm param fails with k8s >= 1.33 due to the AL2 images being removed:
Error: reading SSM Parameter (/aws/service/eks/optimized-ami/1.34/amazon-linux-2/recommended/image_id): couldn't find resource
Private-ref: https://tasks.opencraft.com/browse/BB-10631
samuelallan72
changed the title
Author
|
Please let me know what would be preferred regarding updating examples here. I could add a new one in examples/self-managed-node-group/ perhaps, with a module that deploys eks k8s 1.33 with ami_type AL2 and an ubuntu ami? I'm not sure if more examples are desired here though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ssm param for the recommended ami is not used if a custom ami is used. Also, if one wishes to use a custom ami with the older AL2 ami_type (uses bootstrap.sh for user_data in launch templates), retrieving the ssm param fails with k8s >= 1.33 due to the AL2 images being removed:
Private-ref: https://tasks.opencraft.com/browse/BB-10631
Motivation and Context
This fixes using self managed node groups with Ubuntu AMIs.
Breaking Changes
I don't believe this breaks backward compatibility.
How Has This Been Tested?
I've tested this patch based on v20.37.2. Ideally we would backport it to the v20 release series, since we're using that at the moment and cannot update right now.
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request