Skip to content

fix: Don't retrieve ssm param if custom ami used #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelallan72 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Don't retrieve ssm param if custom ami used #3660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modules/self-managed-node-group/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ locals {
}

data "aws_ssm_parameter" "ami" {
count = var.create ? 1 : 0
# only pull the ami if we're creating the resource AND we're not already using a custom ami
count = var.create && length(var.ami_id) == 0 ? 1 : 0

region = var.region

Expand Down Expand Up @@ -219,7 +220,7 @@ resource "aws_launch_template" "this" {
arn = var.create_iam_instance_profile ? aws_iam_instance_profile.this[0].arn : var.iam_instance_profile_arn
}

image_id = coalesce(var.ami_id, nonsensitive(data.aws_ssm_parameter.ami[0].value))
image_id = coalesce(var.ami_id, nonsensitive(try(data.aws_ssm_parameter.ami[0].value, "")))
instance_initiated_shutdown_behavior = var.instance_initiated_shutdown_behavior

dynamic "instance_market_options" {
Expand Down
Loading