Skip to content

chore(security): harden examples and refresh secure-default docs#20

Open
anmolnagpal wants to merge 3 commits intomasterfrom
track-c-security-defaults-examples
Open

chore(security): harden examples and refresh secure-default docs#20
anmolnagpal wants to merge 3 commits intomasterfrom
track-c-security-defaults-examples

Conversation

@anmolnagpal
Copy link
Contributor

Summary

  • remove broad public ingress patterns from examples
  • align examples to secure defaults and explicit opt-out paths
  • update README/CHANGELOG with migration guidance

Notes

  • PR only; no merge performed.

@anmolnagpal anmolnagpal requested a review from a team as a code owner February 9, 2026 03:35
@gemini-code-assist
Copy link

Summary of Changes

Hello @anmolnagpal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the security posture of the project by implementing private-first defaults in examples, particularly for Key Vault configurations, and providing clear documentation for managing public access. It also introduces a new workflow baseline policy to standardize GitHub collaboration and CI practices, aiming to reduce supply-chain risks and enhance the reproducibility of continuous integration processes.

Highlights

  • Enhanced Security Defaults: Examples now default to private network access for dependent services like Key Vault, removing broad public ingress patterns and setting public_network_access_enabled = false and ip_rules = [].
  • Clear Opt-Out Guidance: Documentation (README, CHANGELOG) has been updated to provide explicit guidance for users who require public access, detailing how to opt-out of the secure defaults.
  • New Workflow Baseline Policy: A new .github/WORKFLOW_BASELINE.md file has been added, establishing organizational standards for GitHub collaboration, CI hygiene, and Terraform module configurations to improve supply-chain security and reproducibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/WORKFLOW_BASELINE.md
    • Introduced a new document outlining organizational standards for GitHub workflows, pull requests, and Terraform modules.
    • Specifies the use of immutable references (pinned commit SHA or release tag) for reusable workflows.
    • Defines requirements for pull request titles (Conventional Commit, Semantic PR check) and CI pass before merge.
    • Sets standards for Terraform modules, including terraform.required_version, required_providers constraints, and pinned shared workflow refs.
  • CHANGELOG.md
    • Added an entry detailing the hardening of dependent Key Vault usage in examples, specifically setting public_network_access_enabled = false and removing broad ip_rules.
    • Noted the addition of explicit opt-out guidance for public access scenarios in the documentation.
  • README.md
    • Appended a "Security Notes" section.
    • Informed users that examples now employ private-first defaults for services like Key Vault.
    • Provided instructions for explicitly enabling public access (public_network_access_enabled = true) and scoping IP allowlists.
  • examples/complete/example.tf
    • Modified the vault module configuration.
    • Changed public_network_access_enabled from true to false.
    • Replaced ip_rules = ["0.0.0.0/0"] with ip_rules = [], effectively removing broad public IP access.
Ignored Files
  • Ignored by pattern: .github/workflows/** (7)
    • .github/workflows/automerge.yml
    • .github/workflows/checkov.yml
    • .github/workflows/pr_checks.yml
    • .github/workflows/stale_pr.yml
    • .github/workflows/tag-release.yml
    • .github/workflows/terraform-diff.yml
    • .github/workflows/tf-checks.yml
Activity
  • The pull request was created by anmolnagpal.
  • The author noted that this is a "PR only; no merge performed."
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request hardens the security of the examples by disabling public network access for Key Vault and removing permissive IP rules. These are excellent changes that promote a secure-by-default posture. The accompanying documentation updates in the README and CHANGELOG are clear and helpful for users. I have one suggestion to further improve the clarity of the example code by removing a configuration block that has become redundant due to these security enhancements.

Comment on lines 84 to 88
network_acls = {
bypass = "AzureServices"
default_action = "Deny"
ip_rules = ["0.0.0.0/0"]
ip_rules = []
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With public_network_access_enabled set to false on line 81, this network_acls block is no longer effective, as network ACLs only apply when public access is enabled. To improve the clarity of this example and avoid confusion, it's recommended to remove this redundant block entirely.

@anmolnagpal
Copy link
Contributor Author

[gemini-followup-2026-02-09]
Thanks @gemini-code-assist — reviewed the feedback. No repository-local code changes are required at this point; feedback is either informational or blocked by org-level workflow policy configuration.

Where CI is red on title validation, the failure is due to the org reusable workflow regex configuration (terraform-az-modules/.github#29), not this branch's module code.

@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@anmolnagpal
Copy link
Contributor Author

[gemini-followup-2026-02-09]
Reviewed Gemini feedback for this PR. Resolution: addressed/non-blocking for this branch. If PR-title CI fails, it's blocked by org-level workflow regex config (terraform-az-modules/.github#29), not module code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants