chore(security): harden examples and refresh secure-default docs#20
chore(security): harden examples and refresh secure-default docs#20anmolnagpal wants to merge 3 commits intomasterfrom
Conversation
Summary of ChangesHello @anmolnagpal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the security posture of the project by implementing private-first defaults in examples, particularly for Key Vault configurations, and providing clear documentation for managing public access. It also introduces a new workflow baseline policy to standardize GitHub collaboration and CI practices, aiming to reduce supply-chain risks and enhance the reproducibility of continuous integration processes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request hardens the security of the examples by disabling public network access for Key Vault and removing permissive IP rules. These are excellent changes that promote a secure-by-default posture. The accompanying documentation updates in the README and CHANGELOG are clear and helpful for users. I have one suggestion to further improve the clarity of the example code by removing a configuration block that has become redundant due to these security enhancements.
| network_acls = { | ||
| bypass = "AzureServices" | ||
| default_action = "Deny" | ||
| ip_rules = ["0.0.0.0/0"] | ||
| ip_rules = [] | ||
| } |
There was a problem hiding this comment.
|
[gemini-followup-2026-02-09] Where CI is red on title validation, the failure is due to the org reusable workflow regex configuration (terraform-az-modules/.github#29), not this branch's module code. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
[gemini-followup-2026-02-09] |
Summary
Notes