-
Notifications
You must be signed in to change notification settings - Fork 0
chore(security): harden examples and refresh secure-default docs #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anmolnagpal
wants to merge
3
commits into
master
Choose a base branch
from
track-c-security-defaults-examples
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Workflow Baseline Policy | ||
|
|
||
| This repository defines the organization-level baseline for GitHub collaboration and CI hygiene. | ||
|
|
||
| ## Reusable workflow reference policy | ||
|
|
||
| - Do **not** reference reusable workflows with floating refs such as `@master` or `@main`. | ||
| - Use immutable refs: | ||
| - pinned commit SHA (preferred), or | ||
| - immutable release tag. | ||
|
|
||
| Example: | ||
|
|
||
| ```yaml | ||
| uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@88efd7724e007c8f721a219498be29e0c9ad471b | ||
| ``` | ||
|
|
||
| ## Pull request baseline | ||
|
|
||
| - Conventional Commit title required. | ||
| - Semantic PR title check required. | ||
| - CI checks must pass before merge. | ||
|
|
||
| ## Terraform module baseline (org standard) | ||
|
|
||
| For Terraform module repositories, include: | ||
|
|
||
| - `terraform.required_version` in `versions.tf` | ||
| - explicit `required_providers` constraints | ||
| - pinned shared workflow refs in `.github/workflows/*` | ||
|
|
||
| These standards reduce supply-chain risk and improve CI reproducibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
public_network_access_enabledset tofalseon line 81, thisnetwork_aclsblock is no longer effective, as network ACLs only apply when public access is enabled. To improve the clarity of this example and avoid confusion, it's recommended to remove this redundant block entirely.