Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/WORKFLOW_BASELINE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Workflow Baseline Policy

This repository defines the organization-level baseline for GitHub collaboration and CI hygiene.

## Reusable workflow reference policy

- Do **not** reference reusable workflows with floating refs such as `@master` or `@main`.
- Use immutable refs:
- pinned commit SHA (preferred), or
- immutable release tag.

Example:

```yaml
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@88efd7724e007c8f721a219498be29e0c9ad471b
```

## Pull request baseline

- Conventional Commit title required.
- Semantic PR title check required.
- CI checks must pass before merge.

## Terraform module baseline (org standard)

For Terraform module repositories, include:

- `terraform.required_version` in `versions.tf`
- explicit `required_providers` constraints
- pinned shared workflow refs in `.github/workflows/*`

These standards reduce supply-chain risk and improve CI reproducibility.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,4 @@ Write to us at [hello@clouddrove.com](hello@clouddrove.com).

[email]: <>
[github]: https://github.com/terraform-az-modules
[terraform_modules]: https://github.com/orgs/terraform-az-modules/repositories
[terraform_modules]: https://github.com/orgs/terraform-az-modules/repositories
4 changes: 2 additions & 2 deletions examples/complete/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,13 @@ module "vault" {
resource_group_name = module.resource_group.resource_group_name
location = module.resource_group.resource_group_location
subnet_id = module.subnet.subnet_ids.subnet1
public_network_access_enabled = true
public_network_access_enabled = false
sku_name = "premium"
private_dns_zone_ids = module.private_dns_zone.private_dns_zone_ids.key_vault
network_acls = {
bypass = "AzureServices"
default_action = "Deny"
ip_rules = ["0.0.0.0/0"]
ip_rules = []
}
Comment on lines 84 to 88

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With public_network_access_enabled set to false on line 81, this network_acls block is no longer effective, as network ACLs only apply when public access is enabled. To improve the clarity of this example and avoid confusion, it's recommended to remove this redundant block entirely.

reader_objects_ids = {
"Key Vault Administrator" = {
Expand Down
Loading