Skip to content

Conversation

@jessdejong
Copy link
Contributor

Description

GMK Clusters and Topics are getting promoted to GA after the submission of GoogleCloudPlatform/magic-modules#12264. We need to update our public documentation to use our GA resources instead of the google-beta ones. Issue: https://b.corp.google.com/issues/377724373

Checklist

Readiness

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@jessdejong jessdejong requested review from a team as code owners November 6, 2024 19:56
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 6, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@jessdejong jessdejong changed the title Update GMK resource examples now that Clusters and Topic resources are GA docs: Update GMK resource examples now that Clusters and Topic resources are GA Nov 6, 2024
@jessdejong
Copy link
Contributor Author

This may need (but I might not be able to successfully trigger this).

/gcbrun

Copy link

@johndee7310 johndee7310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it for GA

@glasnt
Copy link
Contributor

glasnt commented Nov 21, 2024

Error: Error creating Cluster: googleapi: Error 404: Resource "projects/261919062524/regions/us-central1/subnetworks/default" was not found

This isn't being specifically created in the sample, but I'm not sure if it should exist in the project. You could either use the resource to create the subnetwork specifically, or use the data resource to pull the existing information (https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/compute_subnetwork).

I'll /gcbrun it again to confirm it's not a temporary issue (previous issues were "internal errors", this is something specific)

@jessdejong
Copy link
Contributor Author

"default" subnetworks should exist in the project as long as the compute API is enabled. But I checked and the project with project number "261919062524" is being deleted or already has been deleted.

@jessdejong
Copy link
Contributor Author

I'm confused, why would the CI tests be on a deleted project? Or maybe the project was deleted after the tests were run, which is more likely. I'll look into using the subnet terraform resource in my sample.

@snippet-bot
Copy link

snippet-bot bot commented Nov 22, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@jessdejong
Copy link
Contributor Author

The tests should be running, now that I've updated the Cluster and Topic samples to make their own subnets with the google_compute_subnetwork resource.

@jessdejong
Copy link
Contributor Author

Please let me know if there's anything else that I can do!

@jessdejong
Copy link
Contributor Author

Hi, I'm not able to see what went wrong in the latest CI test. Could someone give me some insights so I can try and fix the errors?

@jessdejong jessdejong requested a review from glasnt November 26, 2024 20:40
@jessdejong
Copy link
Contributor Author

@glasnt My team would like to include the project field on the google_managed_kafka_cluster and google_managed_kafka_topic resource samples. I have already committed these changes, but given that this might not be standard practice (@apeabody), I would like you to take a look at this again if possible. We decided to include the project field in b/377892703.

@jessdejong jessdejong merged commit 9ba27ba into terraform-google-modules:main Nov 26, 2024
5 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…ces are GA (terraform-google-modules#759)

* remove google beta

* Setup subnetwork in sample

* Setup subnetwork in topic sample

* Add project identifier line to cluster and topic samples

* Add project id line to clusters and topics with comment

---------

Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants