Skip to content

docs: Update GMK resource examples now that Clusters and Topic resources are GA #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 26, 2024
Merged

docs: Update GMK resource examples now that Clusters and Topic resources are GA #759

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f6bcff2
remove google beta
jessdejong Nov 6, 2024
74ef654
Merge branch 'main' into promote-gmk
glasnt Nov 21, 2024
fc5e45b
Merge branch 'main' into promote-gmk
glasnt Nov 21, 2024
f2f4405
Setup subnetwork in sample
jessdejong Nov 22, 2024
0165cb5
Merge remote-tracking branch 'origin/promote-gmk' into promote-gmk
jessdejong Nov 22, 2024
8f53627
Setup subnetwork in topic sample
jessdejong Nov 22, 2024
0a702ae
Add project identifier line to cluster and topic samples
jessdejong Nov 26, 2024
c304cdf
Add project id line to clusters and topics with comment
jessdejong Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions managedkafka/managedkafka_create_cluster/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
# [START managedkafka_create_cluster_parent]
# [START managedkafka_create_cluster]
resource "google_managed_kafka_cluster" "default" {
provider = google-beta
cluster_id = "my-cluster-id"
location = "us-central1"
capacity_config {
Expand All @@ -35,6 +34,5 @@ resource "google_managed_kafka_cluster" "default" {
# [END managedkafka_create_cluster]

data "google_project" "default" {
provider = google-beta
}
# [END managedkafka_create_cluster_parent]
3 changes: 0 additions & 3 deletions managedkafka/managedkafka_create_topic/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

# [START managedkafka_create_topic_parent]
resource "google_managed_kafka_cluster" "default" {
provider = google-beta
cluster_id = "my-cluster-id"
location = "us-central1"
capacity_config {
Expand All @@ -34,7 +33,6 @@ resource "google_managed_kafka_cluster" "default" {

# [START managedkafka_create_topic]
resource "google_managed_kafka_topic" "default" {
provider = google-beta
topic_id = "my-topic-id"
cluster = google_managed_kafka_cluster.default.cluster_id
location = "us-central1"
Expand All @@ -44,6 +42,5 @@ resource "google_managed_kafka_topic" "default" {
# [END managedkafka_create_topic]

data "google_project" "default" {
provider = google-beta
}
# [END managedkafka_create_topic_parent]