-
Notifications
You must be signed in to change notification settings - Fork 286
feat(securitycenter): add sample for setting custom endpoint #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(securitycenter): add sample for setting custom endpoint #853
Conversation
glasnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for creating this PR! There are a few things that need to be changed here:
- Please add an internal bug reference to the PR description for this change.
- Security Center samples need to be placed under the
securitycenterfolder and region tag, notsecurity_center(snippetbot should have automatically detected this)
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
@glasnt Done! Please consider adding those requirements to the PR template and |
Co-authored-by: Katie McLaughlin <[email protected]>
|
@glasnt Can you fix the CLA issue from your commit? |
|
Pending internal ping about setting up an appropriate team. |
…rm-google-modules#853) * feat(security_center_v2): add sample for setting custom endpoint * update CODEOWNERS * rename directories and region tags * Update .github/CODEOWNERS Co-authored-by: Katie McLaughlin <[email protected]> * Add CODEOWNERS --------- Co-authored-by: Andrew Peabody <[email protected]> Co-authored-by: Katie McLaughlin <[email protected]> Co-authored-by: Katie McLaughlin <[email protected]>
Description
This sample shows how to set a custom endpoint for the Security Command Center v2 API. This information is essential for Security Command Center customers who enable data residency.
Internal bugs: b/416706500, b/417048968
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): New, work-in-progress page
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review
Note
I only added the
terraform-samples-reviewersteam, because none of the other existing teams are logical owners for this sample. If we need to create a new team for this sample, please let me know who should set that up and who should be on the team.