Skip to content

Conversation

@hegemonic
Copy link
Contributor

@hegemonic hegemonic commented May 11, 2025

Description

This sample shows how to set a custom endpoint for the Security Command Center v2 API. This information is essential for Security Command Center customers who enable data residency.

Internal bugs: b/416706500, b/417048968

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s): New, work-in-progress page

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

Note

I only added the terraform-samples-reviewers team, because none of the other existing teams are logical owners for this sample. If we need to create a new team for this sample, please let me know who should set that up and who should be on the team.

@hegemonic hegemonic requested review from a team as code owners May 11, 2025 17:30
@glasnt glasnt added the snippet-bot:force-run Force snippet-bot runs its logic label May 11, 2025
Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for creating this PR! There are a few things that need to be changed here:

  • Please add an internal bug reference to the PR description for this change.
  • Security Center samples need to be placed under the securitycenter folder and region tag, not security_center (snippetbot should have automatically detected this)

@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label May 11, 2025
@snippet-bot
Copy link

snippet-bot bot commented May 12, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@hegemonic
Copy link
Contributor Author

@glasnt Done! Please consider adding those requirements to the PR template and CONTRIBUTING.md (unless they're already listed, and I just missed them).

Co-authored-by: Katie McLaughlin <[email protected]>
@hegemonic
Copy link
Contributor Author

@glasnt Can you fix the CLA issue from your commit?

@glasnt
Copy link
Contributor

glasnt commented May 12, 2025

Pending internal ping about setting up an appropriate team.

@glasnt glasnt changed the title feat(security_center_v2): add sample for setting custom endpoint feat(securitycenter): add sample for setting custom endpoint May 13, 2025
@glasnt glasnt merged commit 690a755 into terraform-google-modules:main May 13, 2025
4 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…rm-google-modules#853)

* feat(security_center_v2): add sample for setting custom endpoint

* update CODEOWNERS

* rename directories and region tags

* Update .github/CODEOWNERS

Co-authored-by: Katie McLaughlin <[email protected]>

* Add CODEOWNERS

---------

Co-authored-by: Andrew Peabody <[email protected]>
Co-authored-by: Katie McLaughlin <[email protected]>
Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants