Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented May 11, 2025

Files directly in .github/* are not related to code execution changes, but files in .github/workflows/* are.

Prevents full test execution on changes to CODEOWNERS

Description

Fixes issues like #853 running all tests

  • Yes, merge this PR after it is approved

Files directly in .github/* are not related to code execution changes, but files in .github/workflows/* are. 

Prevents full test execution on changes to CODEOWNERS
@glasnt glasnt requested review from a team as code owners May 11, 2025 21:48
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@apeabody
Copy link
Contributor

This PR doesn't change any TF content, and manually validated the PR title

@apeabody apeabody merged commit ca5bf6f into main May 12, 2025
8 of 11 checks passed
@apeabody apeabody deleted the githubworkflows branch May 12, 2025 16:15
@glasnt
Copy link
Contributor Author

glasnt commented May 12, 2025

This didn't work; our change isolation script only operates at the top folder level, so a change to .github/CODEOWNERS is stated to affect .github/

@apeabody
Copy link
Contributor

This didn't work; our change isolation script only operates at the top folder level, so a change to .github/CODEOWNERS is stated to affect .github/

I suppose we could do something special for .github, or technically even just the linter.

niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…orm-google-modules#854)

Files directly in .github/* are not related to code execution changes, but files in .github/workflows/* are. 

Prevents full test execution on changes to CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants