-
Notifications
You must be signed in to change notification settings - Fork 74
fix!: default composer image version #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: default composer image version #149
Conversation
The previous image was not supported anymore on gcp: googleapi: Error 400
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@alexis974 can u plz follow this guide to fix lint issue. |
|
Hello @imrannayer, done ! |
|
/gcbrun |
| type = string | ||
| description = "The version of the aiflow running in the cloud composer environment." | ||
| default = "composer-2.5.0-airflow-2.6.3" | ||
| default = "composer-3-airflow-2.10.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not the valid image version, in composer v2, you need to use a v2.x image version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did work when I used image_version = "composer-3-airflow-2.10.2" with the create_environment_v2 module in version v5.2.0
If we check the Cloud composer version list we can see that for composer v3, minor and patch are not present in version name
|
/gcbrun |
|
@alexis974 can u plz use image from composer 2? Integration test is failing with following error. We need to handle this exception for composer 3. |
As of now, v3 is currently not supported by integration tests in the CI
|
Alright @imrannayer , Notice that it is supported until |
|
/gcbrun |
|
@alexis974 integration test is failing. Can u plz comment this line? Line 30 in 70e07a3
|
Done ! Could you run the workflow again ? @imrannayer |
|
/gcbrun |
1 similar comment
|
/gcbrun |
BEGIN_COMMIT_OVERRIDE
fix!: default composer image version
END_COMMIT_OVERRIDE
The current default composer image is not supported anymore on gcp