Skip to content

fix!: default composer image version #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2025
Merged

fix!: default composer image version #149

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b40b971
fix: default composer image version
alexis974 Nov 15, 2024
8981336
Merge branch 'main' into fix/composer-default-image-version
alexis974 Jan 6, 2025
5b70e81
fix(docs): default composer image version
alexis974 Jan 6, 2025
e2267a9
fix(composer): default composer image version
alexis974 Jan 17, 2025
d2525b2
remove(composer): verify in integration tests
alexis974 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/create_environment_v2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ module "simple-composer-environment" {
| env\_variables | Variables of the airflow environment. | `map(string)` | `{}` | no |
| environment\_size | The environment size controls the performance parameters of the managed Cloud Composer infrastructure that includes the Airflow database. Values for environment size are: `ENVIRONMENT_SIZE_SMALL`, `ENVIRONMENT_SIZE_MEDIUM`, and `ENVIRONMENT_SIZE_LARGE`. | `string` | `"ENVIRONMENT_SIZE_MEDIUM"` | no |
| grant\_sa\_agent\_permission | Cloud Composer relies on Workload Identity as Google API authentication mechanism for Airflow. | `bool` | `true` | no |
| image\_version | The version of the aiflow running in the cloud composer environment. | `string` | `"composer-2.5.0-airflow-2.6.3"` | no |
| image\_version | The version of the aiflow running in the cloud composer environment. | `string` | `"composer-3-airflow-2.10.2"` | no |
| kms\_key\_name | Customer-managed Encryption Key fully qualified resource name, i.e. projects/project-id/locations/location/keyRings/keyring/cryptoKeys/key. | `string` | `null` | no |
| labels | The resource labels (a map of key/value pairs) to be applied to the Cloud Composer. | `map(string)` | `{}` | no |
| maintenance\_end\_time | Time window specified for recurring maintenance operations in RFC3339 format | `string` | `null` | no |
Expand Down
2 changes: 1 addition & 1 deletion modules/create_environment_v2/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ variable "env_variables" {
variable "image_version" {
type = string
description = "The version of the aiflow running in the cloud composer environment."
default = "composer-2.5.0-airflow-2.6.3"
default = "composer-3-airflow-2.10.2"
Copy link
Contributor

@nlevee nlevee Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not the valid image version, in composer v2, you need to use a v2.x image version

Copy link
Contributor Author

@alexis974 alexis974 Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did work when I used image_version = "composer-3-airflow-2.10.2" with the create_environment_v2 module in version v5.2.0

If we check the Cloud composer version list we can see that for composer v3, minor and patch are not present in version name

}

variable "pypi_packages" {
Expand Down
Loading