feat(update-variant)!: allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in place #2195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place Signed-off-by: drfaust92 <[email protected]>
Contributor
Author
|
@apeabody Dont know if tests rely on this but i would super appreciate if we can push this into v35 as well. ill make relevant changes as needed if CI fails 🙏 |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
apeabody
changed the title
Collaborator
|
Verified this is in v6.8.0+ |
apeabody
requested changes
Nov 26, 2024
Collaborator
apeabody
left a comment
apeabody
left a comment
There was a problem hiding this comment.
Thanks for the contriobution @DrFaust92!
Can you please add something to docs/upgrading_to_v35.0.md similar to:
…place Signed-off-by: drfaust92 <[email protected]>
…place Signed-off-by: drfaust92 <[email protected]>
Contributor
Author
|
Thanks apeabody! added the section in the upgrade guide |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
apeabody
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this a breaking change as this will cause a recreate of the node pools once more but subsequent updates will be in place
This is a huge QOL change to allow rolling out machine type changes without node pool recreate and allowing apps to migrate gracefully
upstream ref: https://github.com/hashicorp/terraform-provider-google/blob/main/google/services/container/node_config.go#L1937