Skip to content

feat(update-variant)!: allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in place #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 5, 2024
Merged

feat(update-variant)!: allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in place #2195

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dfa66a
allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in …
DrFaust92 Nov 26, 2024
2e0aa5c
Merge branch 'master' into allow-update-in-place
apeabody Nov 26, 2024
775de54
allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in …
DrFaust92 Nov 27, 2024
8d92779
allow updating disk_type, disk_size_gb, machine_type, enable_gcfs in …
DrFaust92 Nov 27, 2024
a3e9bc4
Merge branch 'master' into allow-update-in-place
apeabody Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions autogen/main/cluster.tf.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,8 +716,6 @@ resource "google_container_cluster" "primary" {
{% if update_variant %}
locals {
force_node_pool_recreation_resources = [
"disk_size_gb",
"disk_type",
"accelerator_count",
"accelerator_type",
"gpu_partition_size",
Expand All @@ -730,15 +728,13 @@ locals {
{% if beta_cluster %}
"local_ssd_ephemeral_count",
{% endif %}
"machine_type",
"placement_policy",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
"enable_gcfs",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
Expand Down
4 changes: 0 additions & 4 deletions modules/beta-private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,8 +610,6 @@ resource "google_container_cluster" "primary" {
*****************************************/
locals {
force_node_pool_recreation_resources = [
"disk_size_gb",
"disk_type",
"accelerator_count",
"accelerator_type",
"gpu_partition_size",
Expand All @@ -622,15 +620,13 @@ locals {
"enable_integrity_monitoring",
"local_ssd_count",
"local_ssd_ephemeral_count",
"machine_type",
"placement_policy",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
"enable_gcfs",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
Expand Down
4 changes: 0 additions & 4 deletions modules/beta-public-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,6 @@ resource "google_container_cluster" "primary" {
*****************************************/
locals {
force_node_pool_recreation_resources = [
"disk_size_gb",
"disk_type",
"accelerator_count",
"accelerator_type",
"gpu_partition_size",
Expand All @@ -601,15 +599,13 @@ locals {
"enable_integrity_monitoring",
"local_ssd_count",
"local_ssd_ephemeral_count",
"machine_type",
"placement_policy",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
"enable_gcfs",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
Expand Down
4 changes: 0 additions & 4 deletions modules/private-cluster-update-variant/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,6 @@ resource "google_container_cluster" "primary" {
*****************************************/
locals {
force_node_pool_recreation_resources = [
"disk_size_gb",
"disk_type",
"accelerator_count",
"accelerator_type",
"gpu_partition_size",
Expand All @@ -574,15 +572,13 @@ locals {
"enable_secure_boot",
"enable_integrity_monitoring",
"local_ssd_count",
"machine_type",
"placement_policy",
"max_pods_per_node",
"min_cpu_platform",
"pod_range",
"preemptible",
"spot",
"service_account",
"enable_gcfs",
"enable_gvnic",
"boot_disk_kms_key",
"queued_provisioning",
Expand Down