Skip to content

Conversation

@mukulpalit-ibm
Copy link
Contributor

@mukulpalit-ibm mukulpalit-ibm commented May 12, 2025

Description

  • Adding Prefix to config aggregator variables.
  • Adding prefix details to variable description.
  • Adding Validations at DA level.

Fix for #217

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor

Looks like the trusted profile module has a bug in it that causes a breaking change when the TP name is renamed -> terraform-ibm-modules/terraform-ibm-trusted-profile#178

We shall discuss internally today to see how to handle..

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to use v3.0.0 of trusted profile module. See release notes on how to prevent breaking change

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm mukulpalit-ibm requested a review from ocofaigh May 19, 2025 12:25
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 7abdb45 into main May 19, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 13706/adding-prefix-to-aggregator branch May 19, 2025 13:19
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants