refactor: Regex validation #751
Conversation
|
Testing ss from UI: 
|
|
2.It allows empty string 3.It verifies the regex pattern |
|
/run pipeline |
|
/run pipeline |
| type = string | ||
| nullable = true | ||
| description = "The prefix to be added to all resources created by this solution. To skip using a prefix, set this value to null or an empty string. The prefix must begin with a lowercase letter and may contain only lowercase letters, digits, and hyphens '-'. It should not exceed 16 characters, must not end with a hyphen('-'), and can not contain consecutive hyphens ('--'). Example: prod-0405-ocp. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)." | ||
| description = "The prefix to be added to all resources created by this solution. Example: prod-0405-ocp. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)." |
There was a problem hiding this comment.
Why have we removed the information of required format in the description?
There was a problem hiding this comment.
@ocofaigh The issue mentioned: “Simplify the description of these fields to avoid specifying the expected pattern, as error messages will be shown to the user dynamically while typing.”
I had removed the part that indicated the pattern accordingly, but now I have reverted those changes.
|
/run pipeline |
|
/run pipeline |
|
Moving this PR to draft. The changes are not in production yet, so it should not be merged until they are live. |
|
@arya-girish-k This is now in prod, can you test it there please? |
@ocofaigh Tested in production,All the changes are reflected . |
Description
https://github.ibm.com/GoldenEye/issues/issues/15220
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR uses the new UI regex validation to enforce input rules on the frontend, making validation easier.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers