Skip to content

refactor: Regex validation #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 6, 2025
Merged

refactor: Regex validation #751

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
04c2423
refactor: regex validation
Jul 30, 2025
e6bbd6e
Testing
Jul 30, 2025
4e0d249
update catalog
Jul 31, 2025
40064e2
Testing
Jul 31, 2025
3518398
Testing
Jul 31, 2025
430a45d
added null pattern
Aug 1, 2025
be58a69
fix: formatted json
Aug 1, 2025
5f2c796
Reverted back validation in varaible.tf
Aug 1, 2025
19f7b81
Merge branch 'main' into regex-validation
arya-girish-k Aug 4, 2025
4c75c51
Addressed review comments
Aug 4, 2025
3f38e90
Merge branch 'main' into regex-validation
arya-girish-k Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,12 @@
},
{
"key": "prefix",
"required": true
"required": true,
"value_constraint": {
"type": "regex",
"description": "Prefix must begin with a lowercase letter and may contain only lowercase letters, digits, and hyphens '-'. It must not end with a hyphen('-'), and cannot contain consecutive hyphens ('--'). It should not exceed 16 characters",
"value": "^$|^__NULL__$|^[a-z](?!.*--)[a-z0-9-]{0,14}[a-z0-9]$"
}
},
{
"key": "cluster_name",
Expand Down Expand Up @@ -655,10 +660,20 @@
"key": "kms_encryption_enabled_cluster"
},
{
"key": "existing_kms_instance_crn"
"key": "existing_kms_instance_crn",
"value_constraint": {
"type": "regex",
"description": "The value provided for 'existing_kms_instance_crn' is not valid.",
"value": "^crn:(.*:){3}(kms|hs-crypto):(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
},
{
"key": "existing_cluster_kms_key_crn"
"key": "existing_cluster_kms_key_crn",
"value_constraint": {
"type": "regex",
"description": "The value provided for 'existing_cluster_kms_key_crn' in not valid.",
"value": "^crn:(.*:){3}(kms|hs-crypto):(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}:key:[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"
}
},
{
"key": "kms_endpoint_type",
Expand All @@ -684,7 +699,12 @@
"key": "kms_encryption_enabled_boot_volume"
},
{
"key": "existing_boot_volume_kms_key_crn"
"key": "existing_boot_volume_kms_key_crn",
"value_constraint": {
"type": "regex",
"description": "The value provided for 'existing_boot_volume_kms_key_crn' in not valid.",
"value": "^crn:(.*:){3}(kms|hs-crypto):(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}:key:[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"
}
},
{
"key": "boot_volume_kms_key_name"
Expand Down Expand Up @@ -776,7 +796,7 @@
"hidden": true
},
{
"key":"enable_kube_audit"
"key": "enable_kube_audit"
},
{
"key": "audit_deployment_name"
Expand All @@ -801,7 +821,12 @@
"key": "audit_webhook_listener_image"
},
{
"key": "audit_webhook_listener_image_tag_digest"
"key": "audit_webhook_listener_image_tag_digest",
"value_constraint": {
"type": "regex",
"description": "The value of the audit webhook listener image version must match the tag and sha256 image digest format",
"value": "^[a-f0-9]{40}@sha256:[a-f0-9]{64}$"
}
}
],
"dependencies": [
Expand Down
2 changes: 1 addition & 1 deletion solutions/fully-configurable/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ variable "ibmcloud_api_key" {
variable "prefix" {
type = string
nullable = true
description = "The prefix to be added to all resources created by this solution. To skip using a prefix, set this value to null or an empty string. The prefix must begin with a lowercase letter and may contain only lowercase letters, digits, and hyphens '-'. It should not exceed 16 characters, must not end with a hyphen('-'), and can not contain consecutive hyphens ('--'). Example: prod-0405-ocp. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)."
description = "The prefix to be added to all resources created by this solution. Example: prod-0405-ocp. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have we removed the information of required format in the description?

Copy link
Contributor Author

@arya-girish-k arya-girish-k Aug 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocofaigh The issue mentioned: “Simplify the description of these fields to avoid specifying the expected pattern, as error messages will be shown to the user dynamically while typing.”
I had removed the part that indicated the pattern accordingly, but now I have reverted those changes.


validation {
# - null and empty string is allowed
Expand Down