Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Nov 15, 2024

Description

Migrating ESO to Public

issue: https://github.ibm.com/orgs/GoldenEye/projects/3/views/1?filterQuery=assignee%3A%40me&pane=issue&itemId=677569

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

@imprateeksh
Copy link
Member

@Khuzaima05 - Please update this PR with the latest changes.

@Khuzaima05 Khuzaima05 marked this pull request as ready for review January 13, 2025 09:30
@Khuzaima05 Khuzaima05 self-assigned this Jan 13, 2025
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 requested a review from vbontempi January 15, 2025 08:17
@Khuzaima05
Copy link
Member Author

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@vbontempi
Copy link
Member

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@vbontempi
Copy link
Member

/run pipeline

@vbontempi
Copy link
Member

looks ok now
just the comment at https://github.com/terraform-ibm-modules/terraform-ibm-external-secrets-operator/pull/6/files#r1934004134 seems to be not addressed yet.
But it could make sense to keep as-is, as a different domain would need to configure it in the CIS instance.

@vbontempi
Copy link
Member

/run pipeline

@vbontempi
Copy link
Member

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbontempi I left some comments related to the new image / chart inputs

@vbontempi
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit 9343419 into main Feb 11, 2025
2 checks passed
@ocofaigh ocofaigh deleted the migrate_to_public branch February 11, 2025 09:40
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants