generated from terraform-ibm-modules/terraform-ibm-module-template
-
Notifications
You must be signed in to change notification settings - Fork 1
init commit #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
init commit #6
Changes from 3 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
40f7ca0
init commit
33cad1f
init commit
5a8bd7c
added basic example test in pr_test
7331b34
added basic example
c1bb232
update the PR to use public image
4b76eee
update the PR to use public image
758af0f
updated the image logic
345717c
resolve conflicts
2ffdff0
resolve conflicts
21e8dc1
resolve conflicts
4944e7a
testing
dfff84c
updated the all-combined example
e65ede6
updated the all-combined example
8a3f283
updated the PR test
6b338b8
updated the PR test
9929031
updated the PR test
0d8600c
resolve failure
58f8886
resolve failure
d8bfa47
resolve failure
324d750
SKIP UPGRADE TEST
22a5e38
resolve review comments
d991e55
fix pre-commit
36ef821
fix pipeline failure
aff7739
added imagepull-apikey-sm-manager to all-combined ex
568d683
fix pipeline failure
f7d4141
Update variables.tf
Khuzaima05 27e661f
Update variables.tf
Khuzaima05 9c3187c
Update variables.tf
Khuzaima05 4167f9d
resolve review comments
9542709
resolve review comments
2e876c9
Update variables.tf
Khuzaima05 0013296
Update variables.tf
Khuzaima05 08fc57c
fix: addressed PR comments
vbontempi bda792d
Update submodule to latest commit
vbontempi d1d2c0c
Revert "Update submodule to latest commit"
vbontempi 2a0db7c
fix: reviewed images and versions configurations
vbontempi 7067534
fix image and charts
0b30610
updated es_container_registry
59da3b5
fix pre-commit
b09cb8d
update common-dev-asset
abec5d0
fix: resolved conflicts
vbontempi 68aab49
fix: committed common-dev-assets to fix issue
vbontempi c07fd61
fix go file
1be4288
Merge branch 'migrate_to_public' of https://github.com/terraform-ibm-…
vbontempi 6df7990
feat: moved certs common name setting into test code
vbontempi 716988a
feat: added default values
vbontempi 06cd3f5
fix: fixed vars descriptions and reloader chart version
vbontempi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,9 @@ | ||
| # More info about this file at https://github.com/terraform-ibm-modules/common-pipeline-assets/blob/main/.github/workflows/terraform-test-pipeline.md#cra-config-yaml | ||
| version: "v1" | ||
| CRA_TARGETS: | ||
| - CRA_TARGET: "examples/advanced" # Target directory for CRA scan. If not provided, the CRA Scan will not be run. | ||
| CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json` | ||
| PROFILE_ID: "0e6e7b5a-817d-4344-ab6f-e5d7a9c49520" # SCC profile ID (currently set to the FSCloud 1.4.0 profile). | ||
| # SCC_INSTANCE_ID: "" # The SCC instance ID to use to download profile for CRA scan. If not provided, a default global value will be used. | ||
| # SCC_REGION: "" # The IBM Cloud region that the SCC instance is in. If not provided, a default global value will be used. | ||
| # CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs. | ||
| # TF_VAR_sample: "sample value" | ||
| # TF_VAR_other: "another value" | ||
| - CRA_TARGET: "examples/all-combined" | ||
| CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" | ||
| CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs. | ||
| TF_VAR_existing_cis_instance_name: "test_value_for_cis_instance_name" | ||
| TF_VAR_existing_cis_instance_resource_group_id: "test_value_for_cis_instance_rg_id" | ||
| TF_VAR_existing_sdnlb_serviceid_name: "test_value_for_existing_sdnlb_serviceid_name" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,40 @@ | ||
| { | ||
| "scc_rules": [] | ||
| "scc_rules": [ | ||
| { | ||
| "scc_rule_id": "rule-216e2449-27d7-4afc-929a-b66e196a9cf9", | ||
| "description": "Check whether Flow Logs for VPC are enabled", | ||
| "ignore_reason": "This rule is not relevant to the module itself, just the VPC resource that is used in the example that is scanned", | ||
| "is_valid": false | ||
| }, | ||
| { | ||
| "scc_rule_id": "rule-64c0bea0-8760-4a6b-a56c-ee375a48961e", | ||
| "description": "Check whether Virtual Private Cloud (VPC) has no public gateways attached", | ||
| "ignore_reason": "This rule is not relevant to the module itself, just the VPC resource that is used in the example that is scanned", | ||
| "is_valid": false | ||
| }, | ||
| { | ||
| "scc_rule_id": "rule-2325054a-c338-474a-9740-0b7034487e40", | ||
| "description": "Check whether OpenShift clusters are accessible only by using private endpoints", | ||
| "ignore_reason": "This rule is not relevant to the module itself, just the OCP cluster resource that is used in the example that is scanned", | ||
| "is_valid": false | ||
| }, | ||
| { | ||
| "scc_rule_id": "rule-4d86c074-097e-4ff3-a763-ccff128388e2", | ||
| "description": "Check whether multifactor authentication (MFA) is enabled at the account level", | ||
| "ignore_reason": "This is an account based rule, so unrelated to this module itself", | ||
| "is_valid": false | ||
| }, | ||
| { | ||
| "scc_rule_id": "rule-0704e840-e443-4781-b9be-ec57469d09c1", | ||
| "description": "Check whether permissions for API key creation are limited and configured in IAM settings for the account owner", | ||
| "ignore_reason": "This is an account based rule, so unrelated to this module itself", | ||
| "is_valid": false | ||
| }, | ||
| { | ||
| "scc_rule_id": "rule-0244c010-fde6-4db3-95aa-8952bd292ac3", | ||
| "description": "Check whether permissions for service ID creation are limited and configured in IAM settings for the account owner", | ||
| "ignore_reason": "This is an account based rule, so unrelated to this module itself", | ||
| "is_valid": false | ||
| } | ||
| ] | ||
| } |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,24 @@ | ||
| # Basic example | ||
| # Basic Example | ||
|
|
||
| <!-- | ||
| The basic example should call the module(s) stored in this repository with a basic configuration. | ||
| Note, there is a pre-commit hook that will take the title of each example and include it in the repos main README.md. | ||
| The text below should describe exactly what resources are provisioned / configured by the example. | ||
| --> | ||
| This module provides a basic example to deploy the External Secrets Operator along with a simple username-password type secret in an IBM Cloud environment. It showcases a comprehensive implementation for managing secrets within a Kubernetes cluster, leveraging IBM Cloud's capabilities for a secure and efficient secret management system. | ||
|
|
||
| An end-to-end basic example that will provision the following: | ||
| - A new resource group if one is not passed in. | ||
| - A new Cloud Object Storage instance. | ||
| ## Actions Performed | ||
|
|
||
| - **Resource Group Handling**: Loads an existing resource group or creates a new one based on the provided variables. | ||
|
|
||
| - **VPC and Subnet Configuration**: Establishes a Virtual Private Cloud (VPC) with associated subnets, setting up network segmentation and ACL rules. | ||
|
|
||
| - **OpenShift Cluster Provisioning**: Deploys an OpenShift (OCP) cluster, tailored for a cloud-native architecture with worker pools for private, transit, and edge network segments. | ||
|
|
||
| - **Secrets Manager Integration**: | ||
| - Either utilizes an existing Secrets Manager instance or creates a new one. | ||
| - Configures IAM engine, policies, and secret groups to manage access and operations on secrets. | ||
|
|
||
| - **External Secrets Operator Configuration**: | ||
| - Deploys the External Secrets Operator in the Kubernetes cluster. | ||
| - Includes configurations for the External Secrets Operator to interact with the Secrets Manager and manage secrets at cluster and namespace levels. | ||
|
|
||
| - **Secret Management**: | ||
| - Sets up a service ID (secret-puller) with IAM policies for accessing secrets from the Secrets Manager. | ||
| - Configures various types of secrets, including IAM service ID API keys and username-password combinations. | ||
| - Demonstrates the deployment of external secrets within Kubernetes, utilizing the configured `ClusterSecretStore` and `SecretStore` instances. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.