Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Nov 25, 2024

Description

  • mark existing_kms_instance_crn as required instead of existing_kms_key_crn in the DA because when a value is passed for existing_kms_instance_crn it will create the root key if no value is passed for existing_kms_key_crn.
  • Updated some of the KMS variable descriptions in the DA

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@maheshwarishikha maheshwarishikha merged commit 337e077 into main Nov 25, 2024
2 checks passed
@maheshwarishikha maheshwarishikha deleted the ocofaigh-patch-1 branch November 25, 2024 15:21
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.23.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants