Skip to content

fix: mark existing_kms_instance_crn as required instead of existing_kms_key_crn in the DA #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

fix: mark existing_kms_instance_crn as required instead of existing_kms_key_crn in the DA #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39ef6ef
fix: mark `existing_kms_instance_crn` as required instead of `existin…
ocofaigh Nov 25, 2024
c9cb375
Update variables.tf
ocofaigh Nov 25, 2024
2586ab0
Update ibm_catalog.json
ocofaigh Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,11 @@
]
},
{
"key": "existing_kms_key_crn",
"required": true
"key": "existing_kms_key_crn"
},
{
"key": "existing_kms_instance_crn"
"key": "existing_kms_instance_crn",
"required": true
},
{
"key": "elasticsearch_key_ring_name"
Expand Down
4 changes: 2 additions & 2 deletions solutions/standard/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ variable "auto_scaling" {

variable "existing_kms_key_crn" {
type = string
description = "The CRN of a Hyper Protect Crypto Services or Key Protect root key to use for disk encryption. If not specified, a root key is created in the KMS instance."
description = "The CRN of a Hyper Protect Crypto Services or Key Protect root key to use for disk encryption. If not specified, a root key is created in the KMS instance specified in the `existing_kms_instance_crn` input."
default = null
}

Expand All @@ -230,7 +230,7 @@ variable "kms_endpoint_type" {

variable "existing_kms_instance_crn" {
type = string
description = "The CRN of a Hyper Protect Crypto Services or Key Protect instance in the same account as the Databases for Elasticsearch instance. This value is used to create an authorization policy if `skip_iam_authorization_policy` is false. If not specified, a root key is created."
description = "The CRN of a Hyper Protect Crypto Services or Key Protect instance. Required to create a new root key if no value is passed with the `existing_kms_key_crn` input. Also required to create an authorization policy if `skip_iam_authorization_policy` is false."
default = null
}

Expand Down