Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Jul 1, 2025

Description

Fixes for recent test failure during renovate PR pipelines

  1. Upgrade test name too long
  2. Security enforced test does not take flags to enable to security
  3. Upgrade test is private, so it has to be run in schematics

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from daniel-butler-irl as a code owner July 1, 2025 09:06
@shemau
Copy link
Contributor Author

shemau commented Jul 1, 2025

/run pipeline

@rajatagarwal-ibm
Copy link
Member

@shemau just like normal tests for Security Enforced, would you like to run upgraded tests on Schematics as well?

@shemau
Copy link
Contributor Author

shemau commented Jul 1, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jul 1, 2025

common-dev-assets and go updates required to include schematics upgrade test functions

@shemau
Copy link
Contributor Author

shemau commented Jul 1, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jul 3, 2025

/run pipeline

Copy link
Contributor

@whoffler whoffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok code engine only deployed in security enforced and fully configurable... and enable_kibana_dashboard needs to be enabled to run into this issue. LGTM

@daniel-butler-irl daniel-butler-irl merged commit 9d75138 into main Jul 4, 2025
2 checks passed
@daniel-butler-irl daniel-butler-irl deleted the fix-tests branch July 4, 2025 11:08
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants