- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2
fix: remove wal_level default values and validation #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /run pipeline | 
| @shemau I think upgrade test will fail (since main branch DA code is broken) | 
| condition = var.configuration != null ? (var.configuration["wal_level"] != null ? contains(["replica", "logical"], var.configuration["wal_level"]) : true) : true | ||
| error_message = "Value for `configuration[\"wal_level\"]` must be either `replica` or `logical`, if specified." | ||
| } | ||
| # skip validation for issue #508 and #512 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to link to #512
| Upgrade fails TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │     "Result": {
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │         "errors": {
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │             "configuration.wal_level": [
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │                 "must be one of: hot_standby, logical"
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │             ]
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │         }
TestRunStandardUpgradeSolution 2024-11-06T15:10:35Z logger.go:66: │     },Because the base branch is broken. No other errors, so skipping upgrade. | 
| /run pipeline | 
| Timeout (reported to ICD). Retrying to see if it was a once off.. | 
| /run pipeline | 
| The test that failed this run passed the first time... TestRunBasicExampleWithFlavor 2024-11-06T15:14:04Z logger.go:66: module.read_only_replica_postgresql_db[0].ibm_database.postgresql_db: Creation complete after 7m52s [id=crn:v1:bluemix:public:databases-for-postgresql:eu-de:a/abac0df06b644a9cabc6e44f55b3880e:f267af9b-bded-4543-aa27-9b6ddad6bde7::] So I am just going to try again. (Oh my page just updated... it was already restarted... so I will follow that) | 
| 🎉 This PR is included in version 3.17.11 🎉 The release is available on: 
 Your semantic-release bot 📦🚀 | 
Description
Following on from #508 and #512, remove the wal_level is being hidden.
Consumers can still set a value, since the field is still present and optional.
The default values no longer set wal_level and the validation is removed.
This PR will need revert / updating when the service changes are deployed
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers