Skip to content

Conversation

@Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Apr 3, 2025

Description

Tutorial doc to configure Landing Zone with Account Base DA to create CBR VPC Zone

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Ak-sky Ak-sky changed the title [DNM] doc: updated diagrams with CBR doc: updated diagrams with CBR Apr 16, 2025
@Ak-sky Ak-sky marked this pull request as ready for review April 16, 2025 16:06
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Akash, some comments. Could we also add a link to this documentation from the description of the existing_vpc_cbr_zone_id input.

I also think that this documentation should be part of https://cloud.ibm.com/docs/secure-infrastructure-vpc?topic=secure-infrastructure-vpc-overview eventually.

@Ak-sky Ak-sky requested a review from vburckhardt April 27, 2025 23:02
Copy link
Member

@vburckhardt vburckhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we need a link on existing_vpc_cbr_zone_id, rather this should use existing_vpc_cbr_zone_id markdown. this link is going to be confusing for DA users, as pointing to terraform logic.

In the previous comment, I meant the reverse, link to the doc from the description of that variable so that people can discover the documentation.

@Ak-sky Ak-sky requested a review from vburckhardt April 29, 2025 15:23
@Ak-sky
Copy link
Member Author

Ak-sky commented May 6, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 1405055 into main May 6, 2025
2 checks passed
@ocofaigh ocofaigh deleted the cbr-updates branch May 6, 2025 15:09
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.4.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants