-
Notifications
You must be signed in to change notification settings - Fork 37
doc: updated diagrams with CBR #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vburckhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Akash, some comments. Could we also add a link to this documentation from the description of the existing_vpc_cbr_zone_id input.
I also think that this documentation should be part of https://cloud.ibm.com/docs/secure-infrastructure-vpc?topic=secure-infrastructure-vpc-overview eventually.
vburckhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we need a link on existing_vpc_cbr_zone_id, rather this should use existing_vpc_cbr_zone_id markdown. this link is going to be confusing for DA users, as pointing to terraform logic.
In the previous comment, I meant the reverse, link to the doc from the description of that variable so that people can discover the documentation.
|
/run pipeline |
|
🎉 This PR is included in version 7.4.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Tutorial doc to configure Landing Zone with Account Base DA to create CBR VPC Zone
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers