fix: give en_source_name a default value

[ocofaigh]

Description

en_source_name was added in https://github.com/terraform-ibm-modules/terraform-ibm-scc/releases/tag/v1.8.22 however in this PR I am giving it a default value of "compliance" which is what the default value was in the provider before they made the input required. By giving it this default value, it will mean consumers will not see any changes when upgrading. Otherwise they might see something like this:

2024/11/28 10:06:12 Terraform apply |       ~ event_notifications {
 2024/11/28 10:06:12 Terraform apply |           ~ source_name        = "compliance" -> "en-name"
 2024/11/28 10:06:12 Terraform apply |             # (4 unchanged attributes hidden)
 2024/11/28 10:06:12 Terraform apply |         }

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

/run pipeline

[ocofaigh]

Upgrade test is failing as expected since the defaul value is chaning:

Messages:   	Resource(s) identified to be updated 
        	            	Name: scc_instance_settings
        	            	Address: module.create_scc_instance.ibm_scc_instance_settings.scc_instance_settings[0]
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"event_notifications":"SECURE_VALUE_HIDDEN_HASH:-d013e717315310b95c978bf593dd01c29003bd2adead1720778eba49"}
        	            	  After: 
        	            		{"event_notifications":"SECURE_VALUE_HIDDEN_HASH:-973e5803b32bb03a516013a6dc95d9cdae020dadce7078cb8501821c"}            	

TestRunBasicExample 2024-11-28T10:32:23Z command.go:185: Terraform will perform the following actions:
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185: 
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:   # module.create_scc_instance.ibm_scc_instance_settings.scc_instance_settings[0] will be updated in-place
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:   ~ resource "ibm_scc_instance_settings" "scc_instance_settings" {
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:         id          = "d7eb47df-7b39-4aac-bdb8-5fd2672deb4b"
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:         # (1 unchanged attribute hidden)
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185: 
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:       ~ event_notifications {
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:           ~ source_name        = "scc-upg-z3m1ok-en" -> "compliance"
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:             # (4 unchanged attributes hidden)
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:         }
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185: 
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:         # (1 unchanged block hidden)
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185:     }
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185: 
TestRunBasicExample 2024-11-28T10:32:23Z command.go:185: Plan: 0 to add, 1 to change, 0 to destroy.

Its non disruptive change an actually is reverting back to original value of "compliance"

[ocofaigh]

/run pipeline

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.8.23 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀