Skip to content

Conversation

@seffradev
Copy link
Contributor

@seffradev seffradev commented Aug 10, 2025

What does this PR do?

This implements a C library manually, on top of the generated Go library.

  • Documentation for the functions we have
  • Contribution documentation
  • Map the existing functions

It depends on #51.

Why is it important?

See #49.

Related issues

@oleg-nenashev oleg-nenashev marked this pull request as ready for review October 20, 2025 19:49
@oleg-nenashev oleg-nenashev self-requested a review as a code owner October 20, 2025 19:49
@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Oct 20, 2025
Copy link
Collaborator

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm the previous discussions, it makes the interface MUCH better. Cgo has a lot of limitations, and ther eis little point of exposing its bare API. This is the right approach, especially given the upcoming C++ adapter in #12 which will be also manual

@oleg-nenashev
Copy link
Collaborator

I will merge this change, with acknowledging that some docs might be missing or a bit off for now

@oleg-nenashev oleg-nenashev merged commit 39a591e into testcontainers:main Oct 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library design proposal Inject informative field names into C Structures

2 participants