Skip to content

Phase 2 of DDA#3

Merged
shiroinekotfs merged 34 commits intomasterfrom
phase-2
Dec 3, 2025
Merged

Phase 2 of DDA#3
shiroinekotfs merged 34 commits intomasterfrom
phase-2

Conversation

@shiroinekotfs
Copy link
Member

@shiroinekotfs shiroinekotfs commented Sep 24, 2025 •
edited
Loading

What's new?

  • Added new ExceptionView to match with the template Get WMI Basic (a7684b5)
  • Updated for AboutForm and ConnectForm to match with the template Get WMI Basic (1e2a6d2 and f10a585)
  • Fix for better UI, with enough spacing and margin between objects
  • Fix for disposing resources (8788c5b, 60222a9, and 788d5f3)
  • For developers: added comments as design documentation, so you can understand what behind the logic

Assignment

Developers: @shiroinekotfs and @anhvlttfs
Reviewer: @anhvlttfs
Moderator: @TheFlightSimsOfficial

@shiroinekotfs shiroinekotfs added the bug Something isn't working label Sep 24, 2025
@shiroinekotfs shiroinekotfs linked an issue Sep 24, 2025 that may be closed by this pull request
Questionable on Hyper-V on customer editions (Windows 10 and 11) #2
Open
@shiroinekotfs shiroinekotfs added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Sep 24, 2025
@shiroinekotfs shiroinekotfs linked an issue Sep 26, 2025 that may be closed by this pull request
Questionable on WMI calls on CheckForAssignableDevice #4
Closed
anhvlttfs and others added 13 commits October 4, 2025 23:02
@anhvlttfs
remove unncessary classes
01a67aa
@shiroinekotfs
Merge pull request #5 from tfslabs/dda-on-client-of-phase-2
1814cf2 
Clients on Phase 2
@shiroinekotfs @anhvlttfs
update for about window
f10a585 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
update connection form
1e2a6d2 
move to defaultUI

Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
add exception handler
a7684b5 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Delete WMIDefaultValues.cs
ff8f8b9 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
add comments for main windows
c28a3d7 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update CheckForAssignableDevice.xaml.cs
6b39b33 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update ChangeMemorySpace.xaml.cs
8996dc3 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update AddDevice.xaml.cs
a00f958 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update HyperVStatus.xaml.cs
a160b11 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update HyperV-DPD.csproj
e53558f 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update MachineMethods.cs
64ee362 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
shiroinekotfs and others added 15 commits December 2, 2025 13:39
@shiroinekotfs @anhvlttfs
Update MainWindow.xaml.cs
34e0f3d 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update MachineMethods.cs
3782e4a 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update MachineMethods.cs
4a9a529 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update AddDevice.xaml.cs
61ad0a5 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update ChangeMemorySpace.xaml.cs
d2cd8a8 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update MachineMethods.cs
66cc5a0 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update CheckForAssignableDevice.xaml.cs
345aa08 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update CheckForAssignableDevice.xaml.cs
27a532a 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update CheckForAssignableDevice.xaml.cs
a9179bb 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
Update CheckForAssignableDevice.xaml.cs
6a0c838 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
refactor for readable
94b502f 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
update for non-pci device list
1f43602 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
update with disclosng resources
60222a9 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
update the UI
7505ab5 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs @anhvlttfs
fix for disposing wmi res
788d5f3 
Co-Authored-By: VLTA of @TheFlightSims <176574466+anhvlttfs@users.noreply.github.com>
@shiroinekotfs shiroinekotfs enabled auto-merge (squash) December 3, 2025 16:31
@shiroinekotfs shiroinekotfs enabled auto-merge (squash) December 3, 2025 16:32
@shiroinekotfs shiroinekotfs removed a link to an issue Dec 3, 2025
Questionable on WMI calls on CheckForAssignableDevice #4
Closed
anhvlttfs
anhvlttfs approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@anhvlttfs anhvlttfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shiroinekotfs shiroinekotfs merged commit 0cc37e3 into master Dec 3, 2025
2 checks passed
@shiroinekotfs shiroinekotfs deleted the phase-2 branch December 3, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anhvlttfs anhvlttfs anhvlttfs approved these changes

Assignees

@shiroinekotfs shiroinekotfs

@anhvlttfs anhvlttfs

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers question Further information is requested

Projects

Windows Server Management Tools on TheFlightSims Labs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Questionable on Hyper-V on customer editions (Windows 10 and 11)

2 participants

@shiroinekotfs @anhvlttfs