docs: update stale Go version requirement and prometheus-operator links - #8733
docs: update stale Go version requirement and prometheus-operator links#8733archy-rock3t-cloud wants to merge 2 commits into
Conversation
34c8a9d to
0b6d25d
Compare
|
Expanded scope to also fix 3 dead external links that were causing the
Verified replacement URLs return HTTP 200 via Also included a small fix on top: This should also unblock the docs check on companion PRs #8734, #8737, #8738, #8739, #8743 once they pick up the rebased main. |
kunalworldwide
left a comment
There was a problem hiding this comment.
Docs fixes look good:
.promu.yaml→.promu.ymltypo fix ✓- Go 1.18+ → 1.26+ version update ✓
coreos/prometheus-operator→prometheus-operator/prometheus-operatororg rename ✓- promtail link update to versioned docs ✓
- Added
mixin.yamlandcodeql-analysis.ymlto the Go version update checklist ✓
One thing: might be worth double-checking that the promtail link (grafana.com/docs/loki/v3.5.x/...) isn't itself about to go stale — Grafana tends to remove old versioned docs paths. The latest path would be more durable, though I can see the argument for pinning to a version that matches the proposal's timeframe.
Otherwise LGTM. This has been sitting for a while — would be good to get it merged.
… change guide Signed-off-by: Artem Muterko <artem@sopho.tech>
…tep) Signed-off-by: Artem Muterko <artem@sopho.tech>
d9fc0d1 to
d7c9a36
Compare
|
@kunalworldwide thanks for the feedback.
Fair point that versioned paths do get pruned eventually. If v3.5.x ever goes too, the right fix is to drop the promtail reference and describe the relabel semantics inline rather than repoint at another dead URL, since there's no live upstream page left to link once a component is EOL. For now v3.5.x is the only thing that resolves. Rebased onto main, so the conflict's cleared and the docs check is green. |
kunalworldwide
left a comment
There was a problem hiding this comment.
Docs-only cleanup, all looks correct:
.promu.ymlspelling fix matches the actual file name in the repo.- Go 1.26+ matches
go.mod. coreos/prometheus-operator→prometheus-operator/prometheus-operatorlinks are the right target (GitHub redirects still work but the direct links are better).- Promtail relabeling links point to the current Loki docs path.
- Lightstep access-token link also resolves.
No code changes, so the risk is minimal. LGTM.
go.mod requires go 1.26.0, but the prerequisites in CONTRIBUTING.md still tell new contributors to install Go 1.22.x. Following the guide as written fails on the first `make build`: go: go.mod requires go >= 1.26.0 Two open PRs already cover the neighbouring drift and are intentionally not duplicated here: thanos-io#8733 updates docs/getting-started.md and the checklist in docs/contributing/how-to-change-go-version.md, and thanos-io#8734 bumps the remaining workflows. Neither touches CONTRIBUTING.md. Signed-off-by: fab <8834143+fabmorais@users.noreply.github.com>
Changes
Update Go requirement from 1.18+ to 1.26+ to match go.mod. Update
coreos/prometheus-operatorlinks toprometheus-operator/prometheus-operator. Add missing workflows to Go version change guide, fix.promu.yaml→.promu.yml.Verification
Checked go.mod and GitHub org redirect.