Conversation
004a14a to
a9bac3c
Compare
f5777b8 to
ace06b5
Compare
8be853a to
c8a211f
Compare
6fda130 to
05217a2
Compare
8d766ea to
6286272
Compare
6286272 to
75ce37e
Compare
9b6209e to
2c75acc
Compare
barrettruth
reviewed
Feb 23, 2025
|
|
||
| @patch("tcf_website.management.commands.fetch_enrollment.session.get") | ||
| def test_fetch_enrollment_success(self, mock_get): | ||
| """Test successful enrollment fetch.""" |
Contributor
There was a problem hiding this comment.
is the rest of the codebase using unittest.mock? This flows a lot better than some of the older tests.
Member
There was a problem hiding this comment.
I don't think so, but future tests should probably use this.
06032dd to
f051ef3
Compare
Jay-Lalwani
previously approved these changes
Mar 17, 2025
ajnye
previously approved these changes
Mar 23, 2025
Member
ajnye
left a comment
There was a problem hiding this comment.
LGTM, we should do some more bug testing and merge this ASAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issues addressed
Testing
To test this, navigate to a course and click the section dropdown to view the updated enrollment for each section. In terms of unit testing, there are two testing modules,
test_enrollment.pyandtest_fetch_enrollment.py.What I did
fetch_enrollment.pyScreenshots
Questions/Discussions/Notes