-
Notifications
You must be signed in to change notification settings - Fork 106
Review OS requirements #4203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review OS requirements #4203
Conversation
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly an improvement. I don't like that quick start becomes longer because of an additional header. It was already too long.
My ideal for quick start is that it fits on a single screen, without scrolling. Perhaps you the quick start guide can simply point to the regular installation guide for the requirements and drop both the OS and system requirements altogether?
Is it still really a quickstart, though, if you ask people to read the full book elsewhere? I'll admit I still struggle with the idea of a quickstart guide. Is it something that's intended for testing and then users are expected to throw the result away and install again, this time properly? If so, then let's include the necessary minimum requirements for a very basic scenario without, let's say, any capsules or hosts (so just OS, memory, fresh system). In any case, that's what I'm trying now -- with a separate requirements module, just for quickstart. Is this what you had in mind @ekohl? Although the changes to the quickstart in this PR were mostly accidental, I'm happy to try and improve that guide as well. |
Looking at https://theforeman-foreman-documentation-preview-pr-4203.surge.sh/nightly/Quickstart/index-foreman-deb.html I'd drop the For Debian they don't add anything because |
It should be the quickest way to get a system up and running, without too many details. I think https://theforeman.org/manuals/3.15/quickstart_guide.html is still a decent example: on my screen I can see all instructions without scrolling. That last part is IMHO really important and something that the current guide fails. Mostly because the headers in this guide are very big and take up a lot of space. So do the tables. |
Rename OS prereq section Move OS requirements before system reqs Move OS table to the beginning Drop OS requirements They are already in system requirements Simplify wording Use more specific wording Fix capitalization Simplify OS table Simplify satellite conditionals Merge quickstart system reqs with regular system reqs This is necessary because the OS reqs that precede the system reqs in the quickstart guide now include `.Additional resources` so the Quickstart's system reqs need a heading. Split system requirements for quickstart Spell out EL when defining EPEL Drop implementation details from quickstart prereqs Apply suggestions from style review Co-authored-by: Brian Angelica <[email protected]>
9876e99 to
f401342
Compare
|
Great, thanks for the information! My takeaway from the conversation so far is that for the installation guides, there are no significant objections to the changes introduced in this PR. It's the quickstart guide that needs a bit more work so I'll focus on that. The goal is to keep the instructions for quickstart short. The goal is not to set up a testing environment that is expected to be discarded. In that case, I'm still concerned about skipping the prerequisites but perhaps that could be solved by transparently explaining the intention for the quickstart guide and by linking to the full installation guide. I'll work on a draft. |
guides/common/assembly_preparing-environment-for-capsule-installation.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Kolb <[email protected]>
These are not 'system prerequisites' and it's all documented in the abstract.
645a108 to
c303fd6
Compare
|
To summarize the latest state of proposed changes for the Quickstart's system requirements:
All this is intended to keep the Quickstart guide as short as possible, and I also raised #4205 to make sure the guide's abstract explains the scope as well. |
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Now it's way shorter and I really like that.
Co-authored-by: Maximilian Kolb <[email protected]>
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM
* Review OS prerequisites and move them * Review quickstart system prerequisites --------- Co-authored-by: Brian Angelica <[email protected]> Co-authored-by: Maximilian Kolb <[email protected]> (cherry picked from commit d9b6c9c)
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Some of this was suggested in #4070 (review), the rest is just to give users a bit smoother experience.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):