Skip to content

Conversation

@aneta-petrova
Copy link
Member

What changes are you introducing?

  • Moving installer details from the Quickstart's abstract to the section on running the installer
  • Adding a new abstract that explains the purpose of the guide

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

This came up during the review of #4203

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

Review checklists

Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):

  • The PR documents a recommended, user-friendly path.
  • The PR removes steps that have been made unnecessary or obsolete.
  • Any steps introduced or updated in the PR have been tested to confirm that they lead to the documented end result.

Style review (by a Technical Writer who did not author the PR):

  • The PR conforms with the team's style guidelines.
  • The PR introduces documentation that describes a user story rather than a product feature.

You don't need to know the details of the installer when you start
reading the guide.
@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Aug 29, 2025
@github-actions
Copy link

github-actions bot commented Aug 29, 2025

@aneta-petrova aneta-petrova mentioned this pull request Aug 29, 2025
15 tasks
@aneta-petrova aneta-petrova removed the Needs testing Requires functional testing label Aug 29, 2025
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two suggestion on how to shorten the module.

As a user that really only want to get Foreman up and running, I am probably copy&pasting any commands that I see and skip reading the intro anyway. So 👍 on keeping it short.

@aneta-petrova
Copy link
Member Author

Thanks for all the suggestions so far! After moving the information from the abstract part of the quickstart to the installer procedure in the previous commits, I now made the installer procedure shorter. Can you please re-review? @ekohl @maximiliankolb

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style-wise LGTM.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective style review done No issues from docs style/grammar perspective and removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Sep 3, 2025
@aneta-petrova aneta-petrova merged commit 568876d into theforeman:master Sep 3, 2025
10 checks passed
@aneta-petrova aneta-petrova deleted the quickstart_review branch September 3, 2025 11:36
aneta-petrova added a commit that referenced this pull request Sep 3, 2025
* Move info on installer to section on running the installer

You don't need to know the details of the installer when you start
reading the guide.

* Update Quickstart abstract

* Make quickstart installer procedure shorter

(cherry picked from commit 568876d)
@aneta-petrova
Copy link
Member Author

Merged to "master" and cherry-picked:

421ac97..17fbcad 3.16 -> 3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants