-
Notifications
You must be signed in to change notification settings - Fork 106
Update Quickstart abstract #4205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Quickstart abstract #4205
Conversation
You don't need to know the details of the installer when you start reading the guide.
|
The PR preview for dbc4c74 is available at theforeman-foreman-documentation-preview-pr-4205.surge.sh The following output files are affected by this PR: |
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made two suggestion on how to shorten the module.
As a user that really only want to get Foreman up and running, I am probably copy&pasting any commands that I see and skip reading the intro anyway. So 👍 on keeping it short.
|
Thanks for all the suggestions so far! After moving the information from the abstract part of the quickstart to the installer procedure in the previous commits, I now made the installer procedure shorter. Can you please re-review? @ekohl @maximiliankolb |
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise LGTM.
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this.
* Move info on installer to section on running the installer You don't need to know the details of the installer when you start reading the guide. * Update Quickstart abstract * Make quickstart installer procedure shorter (cherry picked from commit 568876d)
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
This came up during the review of #4203
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Contributor checklists
Please cherry-pick my commits into:
Review checklists
Tech review (performed by an Engineer who did not author the PR; can be skipped if tech review is unnecessary):
Style review (by a Technical Writer who did not author the PR):