Fixes #38591 - Api calls refactor

[Lukshio]

Remove useApi duplicates, unify calls

[MariaAga]

This makes it so if a users selects all hosts, and opens in a new tab, only the first page is opened, instead of the first 100

[Copilot]

Pull Request Overview

This PR refactors API calls in the JobInvocationDetail component to remove duplicated useApi hooks and unify API call handling. The changes replace multiple useAPI hooks with a single dispatch-based approach using Redux APIActions, and reorganize the code structure for better maintainability.

Key changes:

• Replaced multiple useAPI hooks with unified Redux dispatch approach using APIActions.get
• Restructured component state management and API response handling
• Added new constant JOB_INVOCATION_PAGE for API key management

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
JobInvocationHostTable.js	Major refactor replacing useAPI hooks with Redux dispatch, restructuring state management and API call logic
JobInvocationConstants.js	Added new constant JOB_INVOCATION_PAGE for API key management

[adamruzicka]

Needs a rebase

[Lukshio]

This makes it so if a users selects all hosts, and opens in a new tab, only the first page is opened, instead of the first 100

Can you please retest it now? Opening in new tabs has its own limit

foreman_remote_execution/webpack/JobInvocationDetail/CheckboxesActions.js

Lines 83 to 86 in 2310a73

	if (selectedIds.length <= DIRECT_OPEN_HOST_LIMIT) {
	selectedIds.forEach(id => openLink(templateInvocationPageUrl(id, jobID)));
	return;
	}

[MariaAga]

since nothing calls for the first 100 ( per_page = MAX_HOSTS_API_SIZE) it still only opens the first page instead of the first 100

[MariaAga]

also it auto sets per page to 20 instead of the user per_page

[MariaAga]

changing per_page adds brackets around the search, and then every page change adds more brackets, searching by clicking on the chart doesnt work anymore

[Lukshio]

changing per_page adds brackets around the search, and then every page change adds more brackets, searching by clicking on the chart doesnt work anymore

Fixed

also it auto sets per page to 20 instead of the user per_page

Fixed

since nothing calls for the first 100 ( per_page = MAX_HOSTS_API_SIZE) it still only opens the first page instead of the first 100

I couldn't replicate this issue

[MariaAga]

to replicate - have a job run on 21+ hosts, open the job details page, make sure per page is less than the amount of hosts (usually set to 20) click on the open all tab, the number shown in the modal is the per page number, and not all hosts number

[Lukshio]

to replicate - have a job run on 21+ hosts, open the job details page, make sure per page is less than the amount of hosts (usually set to 20) click on the open all tab, the number shown in the modal is the per page number, and not all hosts number

Added old MAX_HOSTS const to load only first 100

[adamruzicka]

It seems we're polling periodically, without waiting for the previous poll to finish? Could we do something about that?

[Lukshio]

After discussion with @MariaAga new behavior is:

• Open in new tabs in applied to current page if not selected, same for failed open
• All api calls are reduced to 1 which handles ids for selection, failed, etc
• MAX_HOSTS is no longer in use with API, but still with max opened tabs

[Lukshio]

The open in new tab button - should open the page if nothing is selected, should not have the text "The maximum is 100.«", and should have a matching text (in the modal and tooltip) if its opening the selected in the page or the just the page. open all failed - should say open all failed runs from this page, the modal also shouldnt say "the maximum is 100.«", also ,it doesnt open any tabs when clicked

Unable to reproduce not opening page if nothing selected, other fixed

[Lukshio]

The open in new tab button - should open the page if nothing is selected, should not have the text "The maximum is 100.«", and should have a matching text (in the modal and tooltip) if its opening the selected in the page or the just the page. open all failed - should say open all failed runs from this page, the modal also shouldnt say "the maximum is 100.«", also ,it doesnt open any tabs when clicked

Unable to reproduce not opening page if nothing selected, other fixed

Ad. refactored opening new tabs, now it should be working

[MariaAga]

clicking the chart seems to add conditions instead of replacing them
(job_invocation.result = failed) AND ((job_invocation.result = success) AND ((job_invocation.result = failed) AND ((job_invocation.result = cancelled) AND ((job_invocation.result = pending) AND ((job_invocation.result = success) AND ((job_invocation.result = failed)))))))

[Lukshio]

clicking the chart seems to add conditions instead of replacing them (job_invocation.result = failed) AND ((job_invocation.result = success) AND ((job_invocation.result = failed) AND ((job_invocation.result = cancelled) AND ((job_invocation.result = pending) AND ((job_invocation.result = success) AND ((job_invocation.result = failed)))))))

re fixed it, hopefully this will stop the circle of fixing something, and breaking something else :)

[MariaAga]

Seems to work as expected now! thats quite a lot of changes, @kmalyjur can you take a look as well to make sure I'm not missing anything?

[kmalyjur]

Thank you, it works as it should, and the code is great except for these minor things. 🎆

[kmalyjur]

Thank you for your edits! I'll be a bit annoying and leave one last comment, but after that, it should be ready to get merged. However, after yesterday's discussion on the planning, we'll need to wait a little before merging.

[Lukshio]

Rebase

[MariaAga]

Thanks everyone!