Fixes #38597 - Add 'Scheduled' option

[Lukshio]

#988 Is required for this one

[adamruzicka]

Blocked on #988 (comment) and a rebase

[Lukshio]

Rebase

[MariaAga]

The chart should reflect this as well, currently clicking on the chart changes the filter to "success"

[MariaAga]

Also, not sure if its in the scope of this PR, but searching for name ~ * gives empty results for "all results" and "Scheduled" (if there are only scheduled hosts)

[Lukshio]

Also, not sure if its in the scope of this PR, but searching for name ~ * gives empty results for "all results" and "Scheduled" (if there are only scheduled hosts)

After discussion with @adamruzicka about this. We decided to do just this "quick fix" for the scheduled option. Because the filter itself is written in some way, that does not allow us to quickly add this option without breaking things or do lot of work to get it done. So the answer is: Yes, it's out of scope of this PR

[Lukshio]

The chart should reflect this as well, currently clicking on the chart changes the filter to "success"

I took a look at this issue, and it actually looks like, that it is a bug, because I don't think it should filter 'success' while all of the jobs are 'awaiting'. Or does it have some special behavior? That is also question for @kmalyjur

I think the issue is here:

foreman_remote_execution/webpack/JobInvocationDetail/JobInvocationSystemStatusChart.js

Lines 69 to 77 in 313d8b0

	const onChartClick = (_evt, { index }) => {
	const statusKeys = Object.keys(STATUS_TITLES);
	const selectedKey = statusKeys[index + 1]; // first status is ALL_STATUSES
	const selectedFilter = selectedKey ? STATUS_TITLES[selectedKey]?.id : null;
	if (onFilterChange && selectedFilter) {
	onFilterChange(selectedFilter);
	}
	};

The index skips "ALL_STATUSES", but it skips it also when there are not any finished jobs.

Then there is a question what is the correct behavior:
When all of the jobs are awaiting clicking on chart:

1. Filter only scheduled jobs
2. Filter all statuses

[kmalyjur]

it is a bug, because I don't think it should filter 'success' while all of the jobs are 'awaiting'

You're right, it's a bug, it probably happened because I and others forgot about the scheduling option.

1. Filter only scheduled jobs
2. Filter all statuses

The first option makes more sense for me.

[Lukshio]

After some time of investigating, I added this minimalist fix, it should be fine now. @kmalyjur

3d137c3#diff-a8d318f6a8e6229ab923d8d228378f32cabfd5c03ce9c9e6fb168a2eaa14f983R79-R83

3d137c3#diff-a8d318f6a8e6229ab923d8d228378f32cabfd5c03ce9c9e6fb168a2eaa14f983R103

[MariaAga]

Thank you!