Do not bind SIGTERM in Windows

[taras]

Motivation

Problem 1: Binding SIGTERM in windows in Deno triggers this warning Windows only supports ctrl-c (SIGINT), ctrl-break (SIGBREAK), and ctrl-close (SIGUP). We don't want main to produce any warnings.

To verify that this is working on Windows, I ran tests on windows. Which lead to Problem 2: TypeError: Windows only supports ctrl-c (SIGINT), ctrl-break (SIGBREAK), and ctrl-close (SIGUP), but got SIGTERM (note the but got SIGTERM)

Approach

The solution to problem 1 is to avoid binding SIGTERM in Deno and Node using their platform flags.

The solution to problem 2 is to use ctrlc-windows instead of sending SIGINT to terminate in Windows.

The test produced stderr which caused the test to fail in pwsh. In bash, it would hang because bash is capturing command's stderr which disrupted ctrlc-windows function. In @effectionx/process we use ctrlc-windows with a process in detached mode which bypasses this problem. I used cmd shell which doesn't disrupt stderr like bash, nor fails the process when stderr is produced.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thefrontside/effection@1031

commit: 9e96b4b

[cowboyd]

Odd. It looks like the tests don't fail on Windows, but they don't pass either.

[taras]

It's wierd that looks like it succeeds, but I can reproduce it locally that in pwsh it's returning status code 1. It's defaulting to pwsh, but passes successfully on bash, so I'm just going to switch it to bash.

[taras]

Now it's hanging on the main.test.ts in Windows bash.

[taras]

The test produced stderr which caused the test to fail in pwsh. In bash, it would hang because bash is capturing command's stderr which disrupted ctrlc-windows function. In @effectionx/process we use ctrlc-windows with a process in detached mode which bypasses this problem. Here, I had to use cmd shell which doesn't disrupt stderr like bash, nor fail the process when stderr is produced.