Update _anndata.py - Clarify a bug & Add Subsetting Functionality#1182
Open
jwalewski wants to merge 2 commits intotheislab:mainfrom
Open
Update _anndata.py - Clarify a bug & Add Subsetting Functionality#1182jwalewski wants to merge 2 commits intotheislab:mainfrom
jwalewski wants to merge 2 commits intotheislab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The one change I wish to make relates to the error handling present in an edge case to do with merging:
Bug fixes
New
Throughout my time using scvelo I really wished that it was possible to directly subset based on observations being equal to a specific value (as compared to taking entire variables), so I wrote a subset_by_value function for my own work. I think it is helpful enough to be included in the repository as a whole.
Let me know if there is any other functionality that should be included in it and/or what tests should be run before it is merged into the main branch.
Linked issue
#1183