Skip to content

add VELOVI preprocess methods#1228

Draft
martinkim0 wants to merge 1 commit intotheislab:mainfrom
martinkim0:velovi-preprocess
Draft

add VELOVI preprocess methods#1228
martinkim0 wants to merge 1 commit intotheislab:mainfrom
martinkim0:velovi-preprocess

Conversation

@martinkim0
Copy link

  • adds min_max_scale, filter_genes_r2, and velovi_preprocess_recipe to preprocessing.utils

to-do:

  • add tests
  • add get_permutation_scores

@martinkim0
Copy link
Author

martinkim0 commented Mar 27, 2024

Hi @WeilerP, this is the PR based on our discussion in scverse/scvi-tools#2611. I wanted to get your thoughts on the following:

  • where should I add get_permutation_scores?
  • under what section in api.rst should velovi_preprocess_recipe be in?

cc @adamgayoso

@martinkim0 martinkim0 marked this pull request as draft March 27, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant