Skip to content

fix: Remove trailing commas in test arrays for rector 2.2.7 compatibility#62

Closed
Copilot wants to merge 6 commits intodependabot/composer/rector/rector-2.2.7from
copilot/sub-pr-61
Closed

fix: Remove trailing commas in test arrays for rector 2.2.7 compatibility#62
Copilot wants to merge 6 commits intodependabot/composer/rector/rector-2.2.7from
copilot/sub-pr-61

Conversation

Copy link

Copilot AI commented Nov 3, 2025

Rector 2.2.7 has a PhpParser bug (TokenStream::getIndentationBefore() returns null) triggered by trailing commas after array closing brackets in named arguments.

Changes

Removed trailing commas after ] in named argument array parameters across test files:

// Before
$event = new EventCandidate(
    source: 'https://www.eventsourcingdb.io',
    subject: '/test',
    type: 'io.eventsourcingdb.test',
    data: [
        'value' => 23,
    ],  // ← Trailing comma triggers PhpParser bug
);

// After
$event = new EventCandidate(
    source: 'https://www.eventsourcingdb.io',
    subject: '/test',
    type: 'io.eventsourcingdb.test',
    data: [
        'value' => 23,
    ]
);

Files modified: CloudEventSignatureTest, CloudEventTest, ObserveEventsTest, ReadEventTypeTest, ReadEventTypesTest, ReadEventsTest, ReadSubjectsTest, RegisterEventSchemaTest, RunEventQlQueryTest, WriteEventsTest


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 5 commits November 3, 2025 05:52
…ity issue

Co-authored-by: goloroden <906327+goloroden@users.noreply.github.com>
Co-authored-by: goloroden <906327+goloroden@users.noreply.github.com>
…ssue

Co-authored-by: goloroden <906327+goloroden@users.noreply.github.com>
…compatibility

Co-authored-by: goloroden <906327+goloroden@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 3, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/Nyholm/psr7/zipball/a71f2b11690f4b24d099d6b16690a90ae14fc6f3
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/beluga-php/docker-php-api/zipball/7db28dbd898211ba44bc582a660ec5e7cce12e2e
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/clue/stream-filter/zipball/049509fef80032cb3f051595029ab75b49a3c2f7
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/janephp/json-schema-runtime/zipball/ddb82546a1fa29456fb9acaa3c1a299beb0b40b1
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/janephp/open-api-runtime/zipball/bf05ecae7096ccb3bd115fadb9b612e26c702d56
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-fig/http-client/zipball/bb5906edc1c324c9a05aa0873d40117941e5fa90
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-fig/http-factory/zipball/2b4765fddfe3b508ac62f829e852b1501d3f6e8a
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-fig/http-message/zipball/402d35bcb92c70c026d1a6a9883f06b2ead23d71
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-http/client-common/zipball/0cfe9858ab9d3b213041b947c881d5b19ceeca46
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-http/discovery/zipball/82fe4c73ef3363caed49ff8dd1539ba06044910d
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/php-http/httplug/zipball/5cad731844891a4c282f3f3e1b582c46839d22f4
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-http/message/zipball/06dd5e8562f84e641bf929bfe699ee0f5ce8080a
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-http/multipart-stream-builder/zipball/10086e6de6f53489cca5ecc45b6f468604d3460e
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-http/promise/zipball/fc85b1fba37c169a69a07ef0d5a8075770cc1f83
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/php-http/socket-client/zipball/94290f4b3aaf50c63d4f8530c448da5be253adba
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/raphaelstolt/php-jsonpointer/zipball/fd50fc1aecd80dedb5bc59c9a1d70d4cfec7933b
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/environment/zipball/a5c75038693ad2e8d4b6c15ba2403532647830c4
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/exporter/zipball/3473f61172093b2da7de1fb5782e1f24cc036dc3
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/global-state/zipball/3be331570a721f9a4b5917f4209773de17f747d7
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/f5b498e631a74204185071eb41f33f38d64608aa
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/6e1a43b411b2ad34146dee7524cb13a068bb35f9
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/f6458abbf32a6c8174f8f26261475dc133b3d9dc
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/type/zipball/f77d2d4e78738c98d9a68d2596fe5e8fa380f449
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/sebastianbergmann/version/zipball/c687e3387b99f5b03b6caa64c74b63e2936ff874
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/staabm/side-effects-detector/zipball/d8334211a140ce329c13726d4a715adbddd0a163
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/p015sp /usr/bin/composer install (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/symfony/options-resolver/zipball/0ff2f5c3df08a395232bbc3c2eb7e84912df911d
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/symfony/polyfill-ctype/zipball/a3cc8b044a6ea513310cbd48ef7333b384945638
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/symfony/polyfill-php80/zipball/0cc9dd0f17f61d8131e7df6b84bd344899fe2608
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/symfony/polyfill-php83/zipball/17f6f9a6b1735c0f163024d959f700cfbc5155e5
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/p015sp /usr/bin/composer install (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/symfony/polyfill-php84/zipball/d8ced4d875142b6a7426000426b8abc631d6b191
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/p015sp /usr/bin/composer install (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/symfony/serializer/zipball/5608b04d8daaf29432d76ecc618b0fac169c2dfb
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/symfony/translation-contracts/zipball/df210c7a2573f1913b2d17cc95f90f53a73d8f7d
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/p015sp /usr/bin/composer install (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/symfony/validator/zipball/a2f26d7c122393db75a2d41435ad8251250f8bc6
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/p015sp /usr/bin/composer install (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/ndZY1w /usr/bin/composer update rector/rector --with-dependencies (http block)
  • https://api.github.com/repos/symfony/yaml/zipball/d4f4a66866fe2451f61296924767280ab5732d9d
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/thephpleague/uri-interfaces/zipball/08cfc6c4f3d811584fb09c37e2849e6a7f9b0742
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)
  • https://api.github.com/repos/thephpleague/uri/zipball/81fb5145d2644324614cc532b28efd0215bda430
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/JqtfRf /usr/bin/composer install --no-progress (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Make requested changes to #61 fix: Remove trailing commas in test arrays for rector 2.2.7 compatibility Nov 3, 2025
Copilot AI requested a review from goloroden November 3, 2025 06:14
@goloroden
Copy link
Member

@copilot Cancel working on this. You don't get it, but you cost us money.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants