Skip to content

fix: Remove trailing commas in test arrays for rector 2.2.7 compatibility #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 6 commits into from
Closed

fix: Remove trailing commas in test arrays for rector 2.2.7 compatibility #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be2bdde
Initial plan
Copilot Nov 3, 2025
f3a4ab8
Downgrade rector/rector from 2.2.7 to 2.2.6 to fix PHP 8.2 compatibil…
Copilot Nov 3, 2025
d42f947
Revert rector to 2.2.5 - both 2.2.6 and 2.2.7 have PhpParser bugs
Copilot Nov 3, 2025
8566c73
Fix trailing commas in test files to resolve rector 2.2.7 PhpParser i…
Copilot Nov 3, 2025
ccece7c
Trigger CI rebuild after rector 2.2.5 cache issue
Copilot Nov 3, 2025
dd0b751
Restore rector 2.2.7 in composer files with code fixes for PhpParser …
Copilot Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/CloudEventSignatureTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function testThrowsAnErrorIfTheSignatureIsNull(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$writtenEvents = $client->writeEvents([
Expand Down Expand Up @@ -76,7 +76,7 @@ public function testThrowsAnErrorIfTheHashVerificationFails(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$writtenEvents = $client->writeEvents([
Expand Down Expand Up @@ -131,7 +131,7 @@ public function testThrowsAnErrorIfTheSignatureVerificationFails(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$writtenEvents = $client->writeEvents([
Expand Down Expand Up @@ -186,7 +186,7 @@ public function testVerifiesTheSignature(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$writtenEvents = $client->writeEvents([
Expand Down
4 changes: 2 additions & 2 deletions tests/CloudEventTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function testVerifiesTheEventHash(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$writtenEvents = $this->client->writeEvents([
Expand All @@ -47,7 +47,7 @@ public function testThrowsAnErrorIfTheEventHashIsInvalid(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$writtenEvents = $this->client->writeEvents([
Expand Down
22 changes: 11 additions & 11 deletions tests/ObserveEventsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function testObserverAllEventsFromTheGivenSubject(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -48,7 +48,7 @@ public function testObserverAllEventsFromTheGivenSubject(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -77,7 +77,7 @@ public function testObserversRecursively(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -86,7 +86,7 @@ public function testObserversRecursively(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -115,7 +115,7 @@ public function testObserversWithLowerBound(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -124,7 +124,7 @@ public function testObserversWithLowerBound(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -160,7 +160,7 @@ public function testObserversFromLatestEvent(): void
type: 'io.eventsourcingdb.test.foo',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -169,7 +169,7 @@ public function testObserversFromLatestEvent(): void
type: 'io.eventsourcingdb.test.bar',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -206,7 +206,7 @@ public function testObserverAllEventsWithAbortInLoop(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -215,7 +215,7 @@ public function testObserverAllEventsWithAbortInLoop(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -249,7 +249,7 @@ public function testObserverAllEventsPerformanceBenchmark(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => rand(1000, 9999),
],
]
);
}

Expand Down
4 changes: 2 additions & 2 deletions tests/ReadEventTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function testReadAnExistingEventType(): void
type: 'io.eventsourcingdb.test.foo',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -42,7 +42,7 @@ public function testReadAnExistingEventType(): void
type: 'io.eventsourcingdb.test.bar',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down
8 changes: 4 additions & 4 deletions tests/ReadEventTypesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function testReadsAllEventTypes(): void
type: 'io.eventsourcingdb.test.foo',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -39,7 +39,7 @@ public function testReadsAllEventTypes(): void
type: 'io.eventsourcingdb.test.bar',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -70,8 +70,8 @@ public function testSupportsReadingEventSchemas(): void
'properties' => [
'value' => [
'type' => 'number',
],
],
]
]
'required' => ['value'],
'additionalProperties' => false,
];
Expand Down
28 changes: 14 additions & 14 deletions tests/ReadEventsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function testReadsAllEventsFromTheGivenSubject(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -46,7 +46,7 @@ public function testReadsAllEventsFromTheGivenSubject(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand All @@ -72,7 +72,7 @@ public function testReadsRecursively(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -81,7 +81,7 @@ public function testReadsRecursively(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand All @@ -107,7 +107,7 @@ public function testReadsChronologically(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -116,7 +116,7 @@ public function testReadsChronologically(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -151,7 +151,7 @@ public function testReadsAntiChronologically(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -160,7 +160,7 @@ public function testReadsAntiChronologically(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -195,7 +195,7 @@ public function testReadsWithLowerBound(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -204,7 +204,7 @@ public function testReadsWithLowerBound(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -236,7 +236,7 @@ public function testReadsWithUpperBound(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -245,7 +245,7 @@ public function testReadsWithUpperBound(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -277,7 +277,7 @@ public function testReadsFromLatestEvent(): void
type: 'io.eventsourcingdb.test.foo',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -286,7 +286,7 @@ public function testReadsFromLatestEvent(): void
type: 'io.eventsourcingdb.test.bar',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down
8 changes: 4 additions & 4 deletions tests/ReadSubjectsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function testReadsAllSubjects(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -37,7 +37,7 @@ public function testReadsAllSubjects(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down Expand Up @@ -65,7 +65,7 @@ public function testReadsAllSubjectsFromTheBaseSubject(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 23,
],
]
);

$secondEvent = new EventCandidate(
Expand All @@ -74,7 +74,7 @@ public function testReadsAllSubjectsFromTheBaseSubject(): void
type: 'io.eventsourcingdb.test',
data: [
'value' => 42,
],
]
);

$this->client->writeEvents([
Expand Down
8 changes: 4 additions & 4 deletions tests/RegisterEventSchemaTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ public function testRegisterAnEventSchema(): void
'properties' => [
'value' => [
'type' => 'number',
],
],
]
]
'required' => ['value'],
'additionalProperties' => false,
];
Expand All @@ -36,8 +36,8 @@ public function testThrowsAnErrorIfAnEventSchemaIsAlreadyRegistered(): void
'properties' => [
'value' => [
'type' => 'number',
],
],
]
]
'required' => ['value'],
'additionalProperties' => false,
];
Expand Down
Loading
Loading