Add peacockContent option to control presence of peacock-exclusive content.#644
Add peacockContent option to control presence of peacock-exclusive content.#644Yanrishatum wants to merge 3 commits intothepeacockproject:masterfrom
Conversation
Undo prettier formatting in menuSystem
|
What's called "isolated unlockableds" should be considered as Peacock exclusive in this case. |
|
Yes and no. They are already present in the game files. Peacock mainly just ties those to challenges. With how inventory currently works - when content is disabled - those items will be treated as "not in any reward pool" and thus available by default. |
Not talking about Twitch drops or click-to-get items. In any case it's not official-like. Unless you just mechanically define the concept of "Peacock exclusive" as "Peacock introducing". |
| contracts = contracts.filter((contract) => { | ||
| if (contract.Peacock?.type === "peacock") { | ||
| // We need to delete the contracts from hardcoded missionsInLocation | ||
| // in order to avoid issues with missing contracts in registry. | ||
| toDelete.add(contract.Metadata.Id) | ||
|
|
||
| if (contract.Metadata.Type === "arcade") { | ||
| orderedETAs.splice( | ||
| orderedETAs.indexOf(contract.Metadata.Id), | ||
| 1, | ||
| ) | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| return true |
There was a problem hiding this comment.
I'm very happy with this PR except for this part. I'd much rather the menu do this filtering rather than delegating it to the internal registration. Otherwise, this won't work for plugins, etc. It also just generally feels out of place here.
Scope
peacockContentoption flag with supported values ofENABLED(default),NOXPandDISABLEDNOXP- challenges tagged withpeacockwill award no mastery XP to preserve (lol) mastery progression balance parity of official servers.DISABLED- removes the challenges and escalations exclusive to Peacock outright.peacocktag. Including challenge packs.typefield forMissionManifest.Peacockfield: Currently only supports value ofpeacockto indicate that manifest is peacock-exclusive content.peacock.User Profile -> Challenges -> Challenge Packsmenu.I've gone through stuff I know of, but I may have missed some challenges or escalations that are peacock-exclusive but not marked.
typefield later can be utilized to filter other types of content that is missing on official servers, like content restoration.Supersedes by #641 as a more generic user-controlled option via
peacockContent=NOXP.Test Plan
peacocktag added.Peacok.typeset to"peacock".peacockContenttoNOXPpeacocktag.DISABLEDOptional:
ENABLEDDISABLEDENABLEDChecklist