Rotating Secret Keys V2 Support #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquim-verges
approved these changes
Feb 13, 2025
jnsdls
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TOOL-3391
PR-Codex overview
This PR focuses on updating the logic for setting the
ClientIdin theThirdwebClientclass and modifying the related unit tests to reflect these changes.Detailed summary
Thirdweb.Client.Tests.cs, updated assertions to checkclient.ClientIdagainstclientIddirectly and ensure it does not equal the computed value fromSecretKey.ThirdwebClient.cs, refactored the logic for settingClientIdto prioritizeclientIdif provided, otherwise compute fromSecretKey.