Skip to content

Rotating Secret Keys V2 Support #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Rotating Secret Keys V2 Support #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Thirdweb.Tests/Thirdweb.Client/Thirdweb.Client.Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ public void ClientIdAndSecretKeyInitialization()
Assert.NotNull(client.ClientId);
Assert.NotNull(client.SecretKey);
Assert.Null(client.BundleId);
Assert.NotEqual(client.ClientId, clientId);
Assert.Equal(client.ClientId, Utils.ComputeClientIdFromSecretKey(client.SecretKey));
Assert.Equal(client.ClientId, clientId);
Assert.NotEqual(client.ClientId, Utils.ComputeClientIdFromSecretKey(client.SecretKey));
Assert.Equal(client.SecretKey, this.SecretKey);
}

Expand Down
13 changes: 3 additions & 10 deletions Thirdweb/Thirdweb.Client/ThirdwebClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,9 @@ private ThirdwebClient(
throw new InvalidOperationException("ClientId or SecretKey must be provided");
}

if (!string.IsNullOrEmpty(secretKey))
{
this.ClientId = Utils.ComputeClientIdFromSecretKey(secretKey);
this.SecretKey = secretKey;
}
else
{
this.ClientId = clientId;
}

// Respects provided clientId if any, otherwise computes it from secretKey
this.ClientId = !string.IsNullOrEmpty(clientId) ? clientId : (string.IsNullOrEmpty(secretKey) ? null : Utils.ComputeClientIdFromSecretKey(secretKey));
this.SecretKey = secretKey;
this.BundleId = bundleId;

this.FetchTimeoutOptions = fetchTimeoutOptions ?? new TimeoutOptions();
Expand Down
Loading