GCP KMS bugfix #710
Merged
GCP KMS bugfix #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4mr
requested review from
joaquim-verges
and removed request for
joaquim-verges
arcoraven
approved these changes
Oct 7, 2024
Comment on lines
43
to
48
| let rawPrivateKey: string | undefined; | ||
| if (clientOptions?.credentials) { | ||
| if ("private_key" in clientOptions.credentials) { | ||
| rawPrivateKey = clientOptions.credentials.private_key; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
IMO a bit clearer to just "sanitize" the private key in clientOptions and continue passing the clientOptions below.
if (clientOptions?.credentials) {
if ("private_key" in clientOptions.credentials) {
clientOptions.credentials.private_key =
clientOptions.credentials.private_key?.split(String.raw`\n`).join("\n");
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug related to GCP application credential private key serialisation/deserialisation
PR-Codex overview
This PR focuses on enhancing the handling of
private_keyinclientOptions.credentialsfor compatibility with both new and older keys in thegetGcpKmsAccount.tsfile.Detailed summary
clientOptions.credentialsexists.private_keyis present, it sanitizes the key by replacing newline characters for backwards compatibility.cryptoKeyVersion.