Skip to content

GCP KMS bugfix #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2024
Merged

GCP KMS bugfix #710

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
643ff3c
replace String.raw`\n` with `\n` in gcp private key
d4mr Oct 7, 2024
ed66110
refactor
d4mr Oct 7, 2024
c4cb199
remove redundant sanitisation
d4mr Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/server/utils/wallets/getGcpKmsAccount.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,18 @@ export async function getGcpKmsAccount(
): Promise<GcpKmsAccount> {
const { name: unprocessedName, clientOptions, client } = options;

if (clientOptions?.credentials) {
if (
"private_key" in clientOptions.credentials &&
clientOptions.credentials.private_key
) {
// https://stackoverflow.com/questions/74131595/error-error1e08010cdecoder-routinesunsupported-with-google-auth-library
// new keys are stored correctly with newlines, but older keys need this sanitization for backwards compatibility
clientOptions.credentials.private_key =
clientOptions.credentials.private_key.split(String.raw`\n`).join("\n");
}
}

// we had a bug previously where we previously called it "cryptoKeyVersion" instead of "cryptoKeyVersions"
// if we detect that, we'll fix it here
// TODO: remove this as a breaking change
Expand Down
Loading