Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 2, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new className prop for the BillingAlerts component, allowing for customized styling. It also integrates the BillingAlerts component into the Layout and modifies its rendering to accommodate the new prop.

Detailed summary

  • Added className prop to BillingAlerts component.
  • Updated BillingAlerts usage in apps/dashboard/src/components/layout/app-shell/index.tsx to include className="py-6".
  • Integrated BillingAlerts in apps/dashboard/src/app/(dashboard)/dashboard/connect/layout.tsx with className="pb-6".
  • Modified BillingAlertsUI to accept and apply className prop for styling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: 514647c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 2, 2024 7:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 2, 2024 7:59pm
wallet-ui ⬜️ Skipped (Inspect) Oct 2, 2024 7:59pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 18:45 Inactive
@jnsdls jnsdls changed the base branch from 10-02-spacing_fixes_on_onboardinggeneral_component to graphite-base/4892 October 2, 2024 18:45
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 2, 2024
@MananTank MananTank marked this pull request as ready for review October 2, 2024 18:45
Copy link
Member Author

MananTank commented Oct 2, 2024

@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (eb8638e) to head (514647c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4892   +/-   ##
=======================================
  Coverage   47.60%   47.60%           
=======================================
  Files        1054     1054           
  Lines       57164    57164           
  Branches     3917     3917           
=======================================
  Hits        27212    27212           
  Misses      29263    29263           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from eb8638e
packages 43.35% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 462 ms (-0.87% 🔽) 1.4 s
thirdweb (cjs) 101.7 KB (0%) 2.1 s (0%) 911 ms (-15.44% 🔽) 3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 47 ms (+6.47% 🔺) 143 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 16 ms (-24.72% 🔽) 26 ms
thirdweb/react (minimal + tree-shaking) 16.74 KB (0%) 335 ms (0%) 92 ms (-9.83% 🔽) 427 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank force-pushed the 10-03-add_billing_alerts_on__connect_layout_in_app_router branch from d82a10e to 0c31e82 Compare October 2, 2024 18:54
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 18:54 Inactive
@jnsdls jnsdls changed the base branch from graphite-base/4892 to main October 2, 2024 18:57
@jnsdls jnsdls force-pushed the 10-03-add_billing_alerts_on__connect_layout_in_app_router branch from 0c31e82 to e712138 Compare October 2, 2024 18:57
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 18:57 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `BillingAlerts` component by allowing it to accept a `className` prop for better styling flexibility. It also updates the usage of `BillingAlerts` in various components to apply specific padding classes.

### Detailed summary
- Modified `BillingAlerts` to accept an optional `className` prop.
- Updated the `BillingAlerts` usage in `apps/dashboard/src/components/layout/app-shell/index.tsx` to include `className="py-6"`.
- Updated `BillingAlerts` usage in `apps/dashboard/src/app/(dashboard)/dashboard/connect/layout.tsx` to include `className="pb-6"`.
- Adjusted the rendering of `BillingAlertsUI` to apply the `className` prop.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-03-add_billing_alerts_on__connect_layout_in_app_router branch from e712138 to 514647c Compare October 2, 2024 19:56
@graphite-app graphite-app bot merged commit 514647c into main Oct 2, 2024
27 checks passed
@graphite-app graphite-app bot deleted the 10-03-add_billing_alerts_on__connect_layout_in_app_router branch October 2, 2024 20:00
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 2, 2024 20:00 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 2, 2024 20:00 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 2, 2024 20:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants