-
Notifications
You must be signed in to change notification settings - Fork 619
Add Billing alerts on /connect layout in app router #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Billing alerts on /connect layout in app router #4892
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4892 +/- ##
=======================================
Coverage 47.60% 47.60%
=======================================
Files 1054 1054
Lines 57164 57164
Branches 3917 3917
=======================================
Hits 27212 27212
Misses 29263 29263
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
d82a10e to
0c31e82
Compare
574e36b to
eb8638e
Compare
0c31e82 to
e712138
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `BillingAlerts` component by allowing it to accept a `className` prop for better styling flexibility. It also updates the usage of `BillingAlerts` in various components to apply specific padding classes.
### Detailed summary
- Modified `BillingAlerts` to accept an optional `className` prop.
- Updated the `BillingAlerts` usage in `apps/dashboard/src/components/layout/app-shell/index.tsx` to include `className="py-6"`.
- Updated `BillingAlerts` usage in `apps/dashboard/src/app/(dashboard)/dashboard/connect/layout.tsx` to include `className="pb-6"`.
- Adjusted the rendering of `BillingAlertsUI` to apply the `className` prop.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
e712138 to
514647c
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces a new
classNameprop for theBillingAlertscomponent, allowing for customized styling. It also integrates theBillingAlertscomponent into theLayoutand modifies its rendering to accommodate the new prop.Detailed summary
classNameprop toBillingAlertscomponent.BillingAlertsusage inapps/dashboard/src/components/layout/app-shell/index.tsxto includeclassName="py-6".BillingAlertsinapps/dashboard/src/app/(dashboard)/dashboard/connect/layout.tsxwithclassName="pb-6".BillingAlertsUIto accept and applyclassNameprop for styling.