Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 2, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new Account Abstraction feature in the dashboard, enhancing user experience with smart wallets. It includes new components, API key management, and alerts to facilitate integration and usage of account abstraction in applications.

Detailed summary

  • Removed account-abstraction.tsx file.
  • Added getAASupportedAPIKeys function to fetch API keys.
  • Created AccountAbstractionAPIKeysMenu for API key selection.
  • Implemented PageHeader with documentation link.
  • Introduced Layout for consistent page structure.
  • Added OpChainAlert for gas credits notifications.
  • Updated SmartWallets to accept defaultTab prop.
  • Created Page component to handle API keys and redirects.
  • Developed a new page for handling client-specific actions with clientId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 8:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 3, 2024 8:58pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 3, 2024 8:58pm
wallet-ui ⬜️ Skipped (Inspect) Oct 3, 2024 8:58pm

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: b31ab5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 20:46 Inactive
@MananTank MananTank marked this pull request as ready for review October 2, 2024 20:46
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 2, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

MananTank commented Oct 2, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 222 ms (+45.03% 🔺) 1.1 s
thirdweb (cjs) 101.63 KB (0%) 2.1 s (0%) 377 ms (+20.78% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 74 ms (+147.88% 🔺) 170 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 40 ms (+970.5% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 135 ms (+111.4% 🔺) 480 ms

@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (b82011e) to head (b31ab5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4896   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57221    57221           
  Branches     3924     3924           
=======================================
  Hits        27246    27246           
  Misses      29286    29286           
  Partials      689      689           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b82011e
packages 43.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank force-pushed the 10-03-move__connect_in-app-wallets_to_app_router branch from a7c947d to 2ac9ad0 Compare October 3, 2024 11:40
@MananTank MananTank force-pushed the 10-03-move__connect_account-abstraction_to_app_router branch from 243000b to e406599 Compare October 3, 2024 11:40
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 11:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 11:40 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 11:40 Inactive
@MananTank MananTank force-pushed the 10-03-move__connect_in-app-wallets_to_app_router branch from 2ac9ad0 to 293305b Compare October 3, 2024 11:58
@MananTank MananTank force-pushed the 10-03-move__connect_account-abstraction_to_app_router branch from e406599 to 215ebb1 Compare October 3, 2024 11:58
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 11:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 20:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 20:28 Inactive
@MananTank MananTank force-pushed the 10-03-move__connect_in-app-wallets_to_app_router branch from 7b11876 to 23cd49d Compare October 3, 2024 20:29
@MananTank MananTank force-pushed the 10-03-move__connect_account-abstraction_to_app_router branch from c8ed1d9 to da52863 Compare October 3, 2024 20:29
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 20:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 20:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 20:29 Inactive
@MananTank MananTank force-pushed the 10-03-move__connect_in-app-wallets_to_app_router branch from 23cd49d to d8ff07e Compare October 3, 2024 20:30
@MananTank MananTank force-pushed the 10-03-move__connect_account-abstraction_to_app_router branch from da52863 to 25d4cf0 Compare October 3, 2024 20:31
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 20:31 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on implementing Account Abstraction features in the dashboard, enhancing the user interface, and integrating API key management for smart wallets.

### Detailed summary
- Removed `account-abstraction.tsx`.
- Added `getAASupportedAPIKeys` function to filter API keys for bundler services.
- Created `AccountAbstractionAPIKeysMenu` to manage API key selection.
- Implemented `PageHeader` for account abstraction context.
- Developed `OpChainAlert` to notify users about gas credits.
- Updated `Layout` with SEO metadata.
- Enhanced `SmartWallets` component to utilize a default tab.
- Created `Page` component to handle authentication and API key redirection.
- Added client ID specific page with account and API key validation.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-03-move__connect_in-app-wallets_to_app_router branch from d8ff07e to b82011e Compare October 3, 2024 20:49
@jnsdls jnsdls force-pushed the 10-03-move__connect_account-abstraction_to_app_router branch from 25d4cf0 to b31ab5a Compare October 3, 2024 20:50
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 3, 2024 20:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 20:50 Inactive
Base automatically changed from 10-03-move__connect_in-app-wallets_to_app_router to main October 3, 2024 20:59
@graphite-app graphite-app bot merged commit b31ab5a into main Oct 3, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 10-03-move__connect_account-abstraction_to_app_router branch October 3, 2024 21:00
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 3, 2024 21:00 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 3, 2024 21:00 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 3, 2024 21:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants