Add Unlimited wallets Banner, Add Team & Legacy dashboard links in headers #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
This was referenced Oct 9, 2024
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
10-09-add_unlimited_wallets_banner_add_team_legacy_dashboard_links_in_headers
branch
from
cd46116 to
5d33505
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4971 +/- ##
=======================================
Coverage 47.74% 47.74%
=======================================
Files 1059 1059
Lines 57328 57328
Branches 3944 3944
=======================================
Hits 27369 27369
Misses 29268 29268
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
MananTank
force-pushed
the
10-09-add_unlimited_wallets_banner_add_team_legacy_dashboard_links_in_headers
branch
from
5d33505 to
9a3a5b6
Compare
jnsdls
approved these changes
Oct 9, 2024
jnsdls
added
the
DO NOT MERGE
Graphite App
jnsdls
requested changes
Oct 9, 2024
Member
jnsdls
left a comment
jnsdls
left a comment
There was a problem hiding this comment.
blocking so we don't accidentally merge early
MananTank
changed the base branch from
10-09-prefill_promose_code_on_coupon_card_from_search_param_scroll_into_view
to
graphite-base/4971
MananTank
force-pushed
the
10-09-add_unlimited_wallets_banner_add_team_legacy_dashboard_links_in_headers
branch
from
11c6a56 to
abd708e
Compare
MananTank
force-pushed
the
10-09-add_unlimited_wallets_banner_add_team_legacy_dashboard_links_in_headers
branch
from
abd708e to
326b0a7
Compare
jnsdls
approved these changes
Oct 10, 2024
jnsdls
removed
the
DO NOT MERGE
Contributor
Merge activity
|
…aders (#4971) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on removing the `DashboardTypeBanner` component and replacing it with the `UnlimitedWalletsBanner` in various files. It also introduces a new tooltip in the `SecondaryNav` and makes minor adjustments to the `BillingHeader` and `AnnouncementBanner`. ### Detailed summary - Deleted `DashboardTypeBanner` component. - Replaced instances of `TryTeamsUIBanner` and `TeamsUIBanner` with `UnlimitedWalletsBanner`. - Added a tooltip in `SecondaryNav` for switching to the legacy dashboard. - Simplified `BillingHeader` by changing the heading style. - Updated `AnnouncementBanner` to include a new `UnlimitedWalletsBanner` function. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
10-09-add_unlimited_wallets_banner_add_team_legacy_dashboard_links_in_headers
branch
from
326b0a7 to
99adbe2
Compare
graphite-app
bot
deleted the
10-09-add_unlimited_wallets_banner_add_team_legacy_dashboard_links_in_headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on removing the
DashboardTypeBannercomponent and replacing its usage with theUnlimitedWalletsBannercomponent in various parts of the application, along with some minor layout adjustments and the addition of a tooltip in theSecondaryNav.Detailed summary
DashboardTypeBannercomponent.TryTeamsUIBannerandTeamsUIBannerwithUnlimitedWalletsBanner.navposition fromfixedtoabsoluteinpage.tsx.SecondaryNavfor switching to the legacy dashboard.BillingHeaderto simplify the header structure.UnlimitedWalletsBannercomponent with specific props.