Add /unlimited-wallets framer path in rewrites, format js files with biome #4972

MananTank · 2024-10-09T16:49:10Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating configuration settings and modifying paths in the next.config.js and next-sitemap.config.js files, as well as adding a new formatter for JavaScript in the .vscode/settings.json file.

Detailed summary

Added a default formatter for javascript in .vscode/settings.json.
Expanded the FRAMER_PATHS array in apps/dashboard/next.config.js to include "/unlimited-wallets".
Changed the fetch URL string format in apps/dashboard/next-sitemap.config.js to use double quotes.
Renamed the parameter _path to path in the transform function in next-sitemap.config.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-09T16:49:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 5:38pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 5:38pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 5:38pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 5:38pm

changeset-bot · 2024-10-09T16:49:16Z

⚠️ No Changeset found

Latest commit: 0c5b0bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-09T16:49:16Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

MananTank · 2024-10-09T16:49:28Z

Add /unlimited-wallets framer path in rewrites, format js files with biome #4972 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

codecov · 2024-10-09T16:51:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.66%. Comparing base (9adf6e6) to head (0c5b0bf).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4972   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files        1057     1057           
  Lines       57267    57267           
  Branches     3939     3939           
=======================================
  Hits        27299    27299           
  Misses      29277    29277           
  Partials      691      691

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 9adf6e6
packages	`43.44% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-10-09T16:56:52Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.1 KB (0%)	842 ms (0%)	178 ms (+129.39% 🔺)	1.1 s
thirdweb (cjs)	101.73 KB (0%)	2.1 s (0%)	229 ms (+4.98% 🔺)	2.3 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	30 ms (+261.86% 🔺)	126 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	45 ms (+3412.7% 🔺)	55 ms
thirdweb/react (minimal + tree-shaking)	17.23 KB (0%)	345 ms (0%)	44 ms (+310.2% 🔺)	388 ms

graphite-app · 2024-10-09T17:24:40Z

Merge activity

Oct 9, 1:24 PM EDT: A user added this pull request to the Graphite merge queue.
Oct 9, 1:39 PM EDT: A user merged this pull request with the Graphite merge queue.

…biome (#4972) ## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on updating configuration settings, version numbers, and making minor adjustments in the codebase, including enhancing the `FRAMER_PATHS` and refining error messages in the UI. ### Detailed summary - Added `editor.defaultFormatter` for `[javascript]` in `.vscode/settings.json`. - Updated `version` from `5.61.3` to `5.61.4` in `packages/thirdweb/package.json`. - Expanded `FRAMER_PATHS` in `apps/dashboard/next.config.js`. - Added a new entry in `packages/thirdweb/CHANGELOG.md` for version `5.61.4`. - Modified error message handling in `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx`. - Changed fetch URL string formatting in `apps/dashboard/next-sitemap.config.js`. - Renamed `_path` to `path` in the `transform` function of `apps/dashboard/next-sitemap.config.js`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

MananTank marked this pull request as ready for review October 9, 2024 16:49

MananTank requested review from jnsdls and joaquim-verges as code owners October 9, 2024 16:49

github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 9, 2024

MananTank mentioned this pull request Oct 9, 2024

Include search params when redirecting to login page #4967

Merged

This was referenced Oct 9, 2024

Prefill Promo code on coupon card from search param + scroll into view #4968

Merged

Add Unlimited wallets Banner, Add Team & Legacy dashboard links in headers #4971

Merged

vercel bot deployed to Preview – thirdweb_playground October 9, 2024 16:50 View deployment

vercel bot deployed to Preview – wallet-ui October 9, 2024 16:51 View deployment

MananTank force-pushed the 10-09-add__unlimited-wallets_framer_path_in_rewrites branch from 6fbfcc6 to 6dd05c2 Compare October 9, 2024 16:53

MananTank changed the title ~~Add /unlimited-wallets framer path in rewrites~~ Add /unlimited-wallets framer path in rewrites, format js files with biome Oct 9, 2024

vercel bot deployed to Preview – wallet-ui October 9, 2024 16:54 View deployment

jnsdls approved these changes Oct 9, 2024

View reviewed changes

vercel bot deployed to Preview – thirdweb_playground October 9, 2024 16:56 View deployment

vercel bot deployed to Preview – docs-v2 October 9, 2024 16:57 View deployment

vercel bot deployed to Preview – thirdweb-www October 9, 2024 17:08 View deployment

MananTank force-pushed the 10-09-add__unlimited-wallets_framer_path_in_rewrites branch from 6dd05c2 to 2ee53c5 Compare October 9, 2024 17:14

MananTank requested review from edwardysun and gregfromstl as code owners October 9, 2024 17:14

MananTank changed the base branch from 10-09-add_unlimited_wallets_banner_add_team_legacy_dashboard_links_in_headers to main October 9, 2024 17:14

vercel bot deployed to Preview – wallet-ui October 9, 2024 17:15 View deployment

vercel bot deployed to Preview – thirdweb_playground October 9, 2024 17:16 View deployment

vercel bot deployed to Preview – docs-v2 October 9, 2024 17:18 View deployment

vercel bot deployed to Preview – thirdweb-www October 9, 2024 17:24 View deployment

MananTank force-pushed the 10-09-add__unlimited-wallets_framer_path_in_rewrites branch from 2ee53c5 to 0c5b0bf Compare October 9, 2024 17:25

vercel bot deployed to Preview – wallet-ui October 9, 2024 17:29 View deployment

vercel bot deployed to Preview – docs-v2 October 9, 2024 17:31 View deployment

vercel bot deployed to Preview – thirdweb_playground October 9, 2024 17:32 View deployment

vercel bot deployed to Preview – thirdweb-www October 9, 2024 17:38 View deployment

graphite-app bot merged commit 0c5b0bf into main Oct 9, 2024
31 checks passed

graphite-app bot deleted the 10-09-add__unlimited-wallets_framer_path_in_rewrites branch October 9, 2024 17:39

vercel bot deployed to Production – wallet-ui October 9, 2024 17:40 View deployment

vercel bot deployed to Production – thirdweb_playground October 9, 2024 17:40 View deployment

vercel bot deployed to Production – docs-v2 October 9, 2024 17:41 View deployment

vercel bot deployed to Production – thirdweb-www October 9, 2024 17:48 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add /unlimited-wallets framer path in rewrites, format js files with biome #4972

Add /unlimited-wallets framer path in rewrites, format js files with biome #4972

MananTank commented Oct 9, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 9, 2024

Uh oh!

MananTank commented Oct 9, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 9, 2024 •

edited by MananTank

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add /unlimited-wallets framer path in rewrites, format js files with biome #4972

Add /unlimited-wallets framer path in rewrites, format js files with biome #4972

Conversation

MananTank commented Oct 9, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Oct 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

MananTank commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Oct 9, 2024 • edited by MananTank Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 9, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 9, 2024 •

edited

Loading

changeset-bot bot commented Oct 9, 2024 •

edited

Loading

MananTank commented Oct 9, 2024 •

edited

Loading

codecov bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

graphite-app bot commented Oct 9, 2024 •

edited by MananTank

Loading