Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 14, 2024

Fixes: DASH-315


PR-Codex overview

This PR focuses on improving the accessibility and functionality of the ColorInput component within the ColorFormGroup by removing the id prop from the ColorInput and addressing a linting issue regarding label controls.

Detailed summary

  • Removed the id prop from the ColorInput component.
  • Added a comment to ignore a linting rule regarding the label element's control association for accessibility.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 926d823

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 4:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 14, 2024 4:32pm
thirdweb-www ⬜️ Skipped (Inspect) Oct 14, 2024 4:32pm
wallet-ui ⬜️ Skipped (Inspect) Oct 14, 2024 4:32pm

@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 14, 2024 15:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 15:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 15:59 Inactive
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Oct 14, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (50e359d) to head (926d823).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5010   +/-   ##
=======================================
  Coverage   47.77%   47.77%           
=======================================
  Files        1058     1058           
  Lines       57276    57276           
  Branches     3947     3947           
=======================================
  Hits        27362    27362           
  Misses      29223    29223           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 50e359d
packages 43.57% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank force-pushed the 10-14-fix_colorinput_label_click_not_triggering_correct_input_in_playground branch from bae70d0 to a590f72 Compare October 14, 2024 16:02
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 16:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 16:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 14, 2024 16:02 Inactive
@linear
Copy link

linear bot commented Oct 14, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.07 KB (0%) 842 ms (0%) 1.9 s (-22.55% 🔽) 2.7 s
thirdweb (cjs) 101.87 KB (0%) 2.1 s (0%) 4.8 s (-13.44% 🔽) 6.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 342 ms (-38.8% 🔽) 439 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 56 ms (-45.71% 🔽) 66 ms
thirdweb/react (minimal + tree-shaking) 17.24 KB (0%) 345 ms (0%) 753 ms (+20.6% 🔺) 1.1 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 14, 2024

Merge activity

@MananTank MananTank force-pushed the 10-14-fix_colorinput_label_click_not_triggering_correct_input_in_playground branch from a590f72 to 926d823 Compare October 14, 2024 16:28
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 14, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 14, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 14, 2024 16:31 Inactive
@graphite-app graphite-app bot merged commit 926d823 into main Oct 14, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-14-fix_colorinput_label_click_not_triggering_correct_input_in_playground branch October 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants