Skip to content

Fix ColorInput label click not triggering correct input in playground #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
+1 −4
Merged

Fix ColorInput label click not triggering correct input in playground #5010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/playground-web/src/app/connect/sign-in/components/ColorFormGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,13 @@ export function ColorFormGroup(props: {
<div className="flex flex-col gap-2 pb-4">
{colorSection.colors.map((color) => {
return (
// biome-ignore lint/a11y/noLabelWithoutControl: input is inside the label, so no need to add id
<label
className="flex cursor-pointer items-center gap-3 rounded-lg p-2 transition-colors hover:bg-secondary"
key={color.colorId}
htmlFor="color-input"
>
<div className="rounded-full border">
<ColorInput
id="color-input"
className="size-10"
value={themeObj.colors[color.colorId]}
onChange={(value) => {
Expand Down
2 changes: 0 additions & 2 deletions apps/playground-web/src/app/connect/sign-in/components/ColorInput/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,13 @@ export function ColorInput(props: {
onChange: (value: string) => void;
onClick?: () => void;
className?: string;
id?: string;
}) {
const debouncedOnChange = useDebouncedCallback((value) => {
props.onChange(value);
}, 100);

return (
<input
id={props.id}
onChange={(e) => {
debouncedOnChange(e.target.value);
}}
Expand Down
Loading